Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2995343002: Migrated test block 216 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 216 to Dart 2.0. No changes made to this block. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/002ebba6f4b1fa0785f39d262c363ceba259e5e8

Patch Set 1 #

Total comments: 4

Patch Set 2 : Migrated min_max_test to Dart 2.0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2112 lines) Patch
M tests/lib/lib.status View 1 3 chunks +0 lines, -3 lines 0 comments Download
D tests/lib/math/min_max_test.dart View 1 chunk +0 lines, -581 lines 0 comments Download
D tests/lib/math/pi_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D tests/lib/math/point_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D tests/lib/math/random_big_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib/math/random_secure_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D tests/lib/math/random_test.dart View 1 chunk +0 lines, -235 lines 0 comments Download
M tests/lib_2/lib_2_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib_2/lib_2_dartdevc.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib_2/lib_2_flutter.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib_2/lib_2_vm.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A + tests/lib_2/math/min_max_test.dart View 1 4 chunks +3 lines, -21 lines 0 comments Download
A + tests/lib_2/math/pi_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/math/point_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/math/random_big_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/math/random_secure_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/math/random_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/lib_strong/lib_strong.status View 1 2 chunks +0 lines, -2 lines 0 comments Download
D tests/lib_strong/math/min_max_test.dart View 1 chunk +0 lines, -581 lines 0 comments Download
D tests/lib_strong/math/pi_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D tests/lib_strong/math/point_test.dart View 1 chunk +0 lines, -99 lines 0 comments Download
D tests/lib_strong/math/random_big_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib_strong/math/random_secure_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D tests/lib_strong/math/random_test.dart View 1 chunk +0 lines, -235 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bkonyi
3 years, 4 months ago (2017-08-21 12:30:52 UTC) #2
Bob Nystrom
https://codereview.chromium.org/2995343002/diff/1/tests/lib_2/lib_2.status File tests/lib_2/lib_2.status (right): https://codereview.chromium.org/2995343002/diff/1/tests/lib_2/lib_2.status#newcode12 tests/lib_2/lib_2.status:12: math/min_max_test: Skip I don't think we want this entry. ...
3 years, 4 months ago (2017-08-23 23:29:03 UTC) #3
bkonyi
https://codereview.chromium.org/2995343002/diff/1/tests/lib_2/lib_2.status File tests/lib_2/lib_2.status (right): https://codereview.chromium.org/2995343002/diff/1/tests/lib_2/lib_2.status#newcode12 tests/lib_2/lib_2.status:12: math/min_max_test: Skip On 2017/08/23 23:29:02, Bob Nystrom wrote: > ...
3 years, 3 months ago (2017-08-30 14:07:41 UTC) #4
Bob Nystrom
On 2017/08/30 14:07:41, bkonyi wrote: > https://codereview.chromium.org/2995343002/diff/1/tests/lib_2/lib_2.status > File tests/lib_2/lib_2.status (right): > > https://codereview.chromium.org/2995343002/diff/1/tests/lib_2/lib_2.status#newcode12 > ...
3 years, 3 months ago (2017-08-30 15:52:53 UTC) #5
Bob Nystrom
lgtm
3 years, 3 months ago (2017-08-30 15:53:05 UTC) #6
bkonyi
3 years, 3 months ago (2017-08-31 14:03:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
002ebba6f4b1fa0785f39d262c363ceba259e5e8.

Powered by Google App Engine
This is Rietveld 408576698