improve analysis server notifications

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_logger.dart';
 import 'package:analysis_server/src/channel.dart';
@@ skipping 50 matching lines @@
    * server.
    */
   List<RequestHandler> handlers;
 
   /**
    * A table mapping context id's to the analysis contexts associated with them.
    */
   final Map<String, AnalysisContext> contextMap = new Map<String, AnalysisContext>();
 
   /**
+   * A table mapping analysis contexts to the context id's associated with them.
+   */
+  final Map<AnalysisContext, String> contextIdMap = new Map<AnalysisContext, String>();
+
+  /**
    * A list of the analysis contexts for which analysis work needs to be
    * performed.
    *
    * Invariant: when this list is non-empty, there is exactly one pending call
    * to [performTask] on the event queue.  When this list is empty, there are
    * no calls to [performTask] on the event queue.
    */
   final List<AnalysisContext> contextWorkQueue = new List<AnalysisContext>();
 
   /**
@@ skipping 74 matching lines @@
       contextWorkQueue.clear();
     }
     if (contextWorkQueue.isEmpty) {
       // Nothing to do.
       return;
     }
     //
     // Look for a context that has work to be done and then perform one task.
     //
     List<ChangeNotice> notices = null;
+    String contextId;
     try {
       AnalysisContext context = contextWorkQueue[0];
+      contextId = contextIdMap[context];
       AnalysisResult result = context.performAnalysisTask();
       notices = result.changeNotices;
     } finally {
       if (notices == null) {
         // Either we have no more work to do for this context, or there was an
         // unhandled exception trying to perform the analysis.  In either case,
         // remove the context form the work queue so we won't try to do more
         // analysis on it.
         contextWorkQueue.removeAt(0);
       }
       //
       // Schedule this method to be run again if there is any more work to be
       // done.
       //
       if (!contextWorkQueue.isEmpty) {
         _scheduleTask();
       }
     }
     if (notices != null) {
-      sendNotices(notices);
+      sendNotices(contextId, notices);
     }
   }
 
   /**
    * Send the information in the given list of notices back to the client.
    */
-  void sendNotices(List<ChangeNotice> notices) {
+  void sendNotices(String contextId, List<ChangeNotice> notices) {
     for (int i = 0; i < notices.length; i++) {
       ChangeNotice notice = notices[i];
       Notification notification = new Notification(ERROR_NOTIFICATION_NAME);
+      notification.setParameter(CONTEXT_ID_PARAM, contextId);
       notification.setParameter(SOURCE_PARAM, notice.source.encoding);
       notification.setParameter(ERRORS_PARAM, notice.errors.map(
           errorToJson).toList());
       sendNotification(notification);
     }
   }
 
   static Map<String, Object> errorToJson(AnalysisError analysisError) {
     // TODO(paulberry): move this function into the AnalysisError class.
 
@@ skipping 19 matching lines @@
   void sendNotification(Notification notification) {
     channel.sendNotification(notification);
   }
 
   void _scheduleTask() {
     new Future(performTask).catchError((ex, st) {
       AnalysisEngine.instance.logger.logError("${ex}\n${st}");
     });
   }
 }