[VM-GC] Add a flag to abort on allocation failure

[VM-GC] Add a flag to abort on allocation failure

This is added to help investigate memory usage. By setting an
old-space limit with --old-gen-heap-size and setting the new
--abort-on-oom it is possible to test whether a program can
run in a certain size. Using binary search one can determine
what the minimum size is. Without this flag the VM will slow
down to a crawl when it tries to exceed its heap limit.
R=vegorov@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/aa1a9ef6866e55919d9aab8c2a71f1bbe79a5e6e

[Vyacheslav Egorov (Google), 2017-08-16 05:22:36]

LGTM

Please provide rationale for this flag in the commit message, e.g. 

"This flag is added to diagnoze OOM situations for an application requiring
large heap... etc"

[davidmorgan, 2017-08-16 11:42:54]

On 2017/08/16 05:22:36, Vyacheslav Egorov (Google) wrote:
> LGTM
> 
> Please provide rationale for this flag in the commit message, e.g. 
> 
> "This flag is added to diagnoze OOM situations for an application requiring
> large heap... etc"

FWIW this did not help with the issue in testing; not sure if it's worth
comitting.

Thanks.

[erikcorry, 2017-09-04 10:30:48]

Description was changed from

==========
[VM-GC] Add a flag to abort on allocation failure

R=vegorov@google.com
BUG=
==========

to

==========
[VM-GC] Add a flag to abort on allocation failure

This is added to help investigate memory usage. By setting an
old-space limit with --old-gen-heap-size and setting the new
--abort-on-oom it is possible to test whether a program can
run in a certain size. Using binary search one can determine
what the minimum size is. Without this flag the VM will slow
down to a crawl when it tries to exceed its heap limit.
R=vegorov@google.com
BUG=
==========

[erikcorry, 2017-09-04 10:32:15]

I think this is a useful option to have to measure heap usage independent of GC
timing, so I'm going to commit it still.

[erikcorry, 2017-09-04 10:32:35]

Description was changed from

==========
[VM-GC] Add a flag to abort on allocation failure

This is added to help investigate memory usage. By setting an
old-space limit with --old-gen-heap-size and setting the new
--abort-on-oom it is possible to test whether a program can
run in a certain size. Using binary search one can determine
what the minimum size is. Without this flag the VM will slow
down to a crawl when it tries to exceed its heap limit.
R=vegorov@google.com
BUG=
==========

to

==========
[VM-GC] Add a flag to abort on allocation failure

This is added to help investigate memory usage. By setting an
old-space limit with --old-gen-heap-size and setting the new
--abort-on-oom it is possible to test whether a program can
run in a certain size. Using binary search one can determine
what the minimum size is. Without this flag the VM will slow
down to a crawl when it tries to exceed its heap limit.
R=vegorov@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/aa1a9ef6866e55919d9aab8c2a71f1bbe79a5e6e
==========

[erikcorry, 2017-09-04 10:32:37]

Committed patchset #2 (id:20001) manually as
aa1a9ef6866e55919d9aab8c2a71f1bbe79a5e6e (presubmit successful).