Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2995053002: Allow caller of application_snapshot to override .packages (Closed)

Created:
3 years, 4 months ago by aam
Modified:
3 years, 4 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, zra
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow caller of application_snapshot to override .packages. This will be used in flutter engine to build snapshot of frontend server dart app. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/e25898d963615091e66dafa08e91caf9e6232086

Patch Set 1 #

Total comments: 2

Patch Set 2 : Group arg logic together #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M utils/application_snapshot.gni View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
aam
PTAL, thanks!
3 years, 4 months ago (2017-08-15 22:29:00 UTC) #3
zra
lgtm w/ slight re-org. https://codereview.chromium.org/2995053002/diff/1/utils/application_snapshot.gni File utils/application_snapshot.gni (right): https://codereview.chromium.org/2995053002/diff/1/utils/application_snapshot.gni#newcode34 utils/application_snapshot.gni:34: } Maybe move the logic ...
3 years, 4 months ago (2017-08-15 22:34:08 UTC) #4
aam
https://codereview.chromium.org/2995053002/diff/1/utils/application_snapshot.gni File utils/application_snapshot.gni (right): https://codereview.chromium.org/2995053002/diff/1/utils/application_snapshot.gni#newcode34 utils/application_snapshot.gni:34: } On 2017/08/15 22:34:07, zra wrote: > Maybe move ...
3 years, 4 months ago (2017-08-15 23:07:26 UTC) #5
aam
3 years, 4 months ago (2017-08-15 23:10:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e25898d963615091e66dafa08e91caf9e6232086 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698