Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2995013002: Migrated test block 170 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 3 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 170 to Dart 2.0. Updated status file to account for strange failure in package:test when running multiple_timer_test on dartdevc. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/a7b19c1b4783111269b636c56b0aa425a161583b

Patch Set 1 #

Patch Set 2 : Fixed issues caused by bug in package:test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -802 lines) Patch
D tests/lib/async/intercept_print1_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/lib/async/intercept_schedule_microtask1_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/lib/async/intercept_schedule_microtask2_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/lib/async/intercept_schedule_microtask3_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D tests/lib/async/intercept_schedule_microtask4_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/lib/async/intercept_schedule_microtask5_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D tests/lib/async/intercept_schedule_microtask6_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/lib/async/multiple_timer_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
D tests/lib/async/print_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
M tests/lib/lib.status View 4 chunks +0 lines, -6 lines 0 comments Download
A tests/lib_2/async/catch_errors.dart View 1 chunk +55 lines, -0 lines 1 comment Download
A + tests/lib_2/async/intercept_print1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/intercept_schedule_microtask1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/intercept_schedule_microtask2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/intercept_schedule_microtask3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/intercept_schedule_microtask4_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/intercept_schedule_microtask5_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/intercept_schedule_microtask6_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/lib_2/async/multiple_timer_test.dart View 1 1 chunk +81 lines, -0 lines 1 comment Download
M tests/lib_2/lib_2.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + tests/lib_2/lib_2_dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download
A + tests/lib_2/lib_2_dartdevc.status View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/lib_2/lib_2_flutter.status View 1 chunk +8 lines, -0 lines 0 comments Download
A + tests/lib_2/lib_2_vm.status View 1 chunk +3 lines, -0 lines 0 comments Download
D tests/lib_strong/async/intercept_print1_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/lib_strong/async/intercept_schedule_microtask1_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/lib_strong/async/intercept_schedule_microtask2_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/lib_strong/async/intercept_schedule_microtask3_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D tests/lib_strong/async/intercept_schedule_microtask4_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/lib_strong/async/intercept_schedule_microtask5_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D tests/lib_strong/async/intercept_schedule_microtask6_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/lib_strong/async/multiple_timer_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
D tests/lib_strong/async/print_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
M tests/lib_strong/lib_strong.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bkonyi
3 years, 4 months ago (2017-08-15 00:01:37 UTC) #2
bkonyi
This block is complete. PTAL.
3 years, 4 months ago (2017-08-16 20:24:54 UTC) #3
Bob Nystrom
lgtm https://codereview.chromium.org/2995013002/diff/20001/tests/lib_2/async/catch_errors.dart File tests/lib_2/async/catch_errors.dart (right): https://codereview.chromium.org/2995013002/diff/20001/tests/lib_2/async/catch_errors.dart#newcode1 tests/lib_2/async/catch_errors.dart:1: library catch_errors; Are there any other tests in ...
3 years, 3 months ago (2017-08-23 21:40:28 UTC) #4
bkonyi
3 years, 3 months ago (2017-08-29 22:25:51 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a7b19c1b4783111269b636c56b0aa425a161583b.

Powered by Google App Engine
This is Rietveld 408576698