Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/debugger.cc

Issue 2994983002: Fix stepping in when paused in async functions. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index 396a86974a67a5e334543a3a445ae54da0175e85..118d6037bcfa1ddde2744690e268cefab72195d3 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -3269,8 +3269,9 @@ void Debugger::SetAsyncSteppingFramePointer() {
if (!FLAG_async_debugger) {
return;
}
- if (stack_trace_->FrameAt(0)->function().IsAsyncClosure() ||
- stack_trace_->FrameAt(0)->function().IsAsyncGenClosure()) {
+ if (stack_trace_->Length() > 0 &&
rmacnak 2017/08/14 20:15:24 if ((stack_trace_->Length() > 0) &&
+ (stack_trace_->FrameAt(0)->function().IsAsyncClosure() ||
+ stack_trace_->FrameAt(0)->function().IsAsyncGenClosure())) {
async_stepping_fp_ = stack_trace_->FrameAt(0)->fp();
} else {
async_stepping_fp_ = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698