Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2994983002: Fix stepping in when paused in async functions. (Closed)

Created:
3 years, 4 months ago by sivachandra
Modified:
3 years, 4 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/vm/debugger.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sivachandra
I spent some time to fix this issue: https://github.com/dart-lang/sdk/issues/30240 I am not able to reproduce ...
3 years, 4 months ago (2017-08-14 15:27:06 UTC) #2
rmacnak
LGTM Note this fixes any kind of step when paused at the root of the ...
3 years, 4 months ago (2017-08-14 20:15:24 UTC) #3
sivachandra
3 years, 4 months ago (2017-08-15 12:14:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ab6d7bba5372205d9a5a7f4e2177fface5696def (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698