Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(609)

Issue 2994903002: Add GN target for jsr305.jar (Closed)

Created:
3 years, 1 month ago by mikecase (-- gone --)
Modified:
3 years, 1 month ago
Reviewers:
jbudorick
CC:
chromium-reviews
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add GN target for jsr305.jar This JAR is a dependency of Robolectric 3.4.2. R=jbudorick@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/findbugs/+/4275d9ac8610db6b1bc9a5e887f97e41b33fac67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
mikecase (-- gone --)
Didn't realize third_party/findbugs was a separate repo. So this is part of my CL to ...
3 years, 1 month ago (2017-08-11 16:11:09 UTC) #2
jbudorick
lgtm
3 years, 1 month ago (2017-08-11 17:26:10 UTC) #3
mikecase (-- gone --)
3 years, 1 month ago (2017-08-11 17:30:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4275d9ac8610db6b1bc9a5e887f97e41b33fac67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698