Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2994883002: Fix couple of vm/cc/DartAPI_* tests for the dartk configuration. (Closed)

Created:
3 years, 4 months ago by sivachandra
Modified:
3 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix couple of vm/cc/DartAPI_* tests for the dartk configuration. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/2ea5140093891b10f79d105fc14114df3f7f9d39

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 chunks +6 lines, -8 lines 0 comments Download
M runtime/vm/unit_test.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sivachandra
A trivial change to make couple of tests work under dartk.
3 years, 4 months ago (2017-08-11 11:51:45 UTC) #2
siva
lgtm
3 years, 4 months ago (2017-08-11 20:03:41 UTC) #3
sivachandra
3 years, 4 months ago (2017-08-14 15:54:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2ea5140093891b10f79d105fc14114df3f7f9d39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698