runtime/vm/object_service.cc - Issue 2994863002: Reapply "Eliminate dependencies on assemblers and code stubs in precompiled runtime."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_service.cc

Issue 2994863002: Reapply "Eliminate dependencies on assemblers and code stubs in precompiled runtime." (Closed)

Patch Set: Exclude references to disassembler in precompiled mode Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object_service.cc

diff --git a/runtime/vm/object_service.cc b/runtime/vm/object_service.cc

index ba23b24e30c422c995a1bff0beaf863d3ae1328b..8579966e44b98de47f697f0d8b25b4fb5e2b6381 100644

--- a/runtime/vm/object_service.cc

+++ b/runtime/vm/object_service.cc

@@ -838,11 +838,13 @@ void Code::PrintJSONImpl(JSONStream* stream, bool ref) const {

jsobj.AddProperty("_objectPool", object_pool);

{

JSONArray jsarr(&jsobj, "_disassembly");

+#if !defined(DART_PRECOMPILED_RUNTIME)

if (is_alive()) {

// Only disassemble alive code objects.

DisassembleToJSONStream formatter(jsarr);

Disassemble(&formatter);

}

+#endif // !defined(DART_PRECOMPILED_RUNTIME)

}

const PcDescriptors& descriptors = PcDescriptors::Handle(pc_descriptors());

if (!descriptors.IsNull()) {

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/redundancy_elimination.cc » ('j') | no next file with comments »