runtime/vm/disassembler_ia32.cc - Issue 2994863002: Reapply "Eliminate dependencies on assemblers and code stubs in precompiled runtime."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 2994863002: Reapply "Eliminate dependencies on assemblers and code stubs in precompiled runtime." (Closed)

Patch Set: Exclude references to disassembler in precompiled mode Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/disassembler_ia32.cc

diff --git a/runtime/vm/disassembler_ia32.cc b/runtime/vm/disassembler_ia32.cc

index 35414588d6fbc79a1d1bd504fca12c265373ffa7..3716d128eff69177a34fb2689d55f923e3ddd7fc 100644

--- a/runtime/vm/disassembler_ia32.cc

+++ b/runtime/vm/disassembler_ia32.cc

@@ -2,10 +2,11 @@

// BSD-style license that can be found in the LICENSE file.

+#include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.

+#if defined(TARGET_ARCH_IA32) && !defined(DART_PRECOMPILED_RUNTIME)

#include "vm/disassembler.h"

-#include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.

-#if defined(TARGET_ARCH_IA32)

#include "platform/utils.h"

#include "vm/allocation.h"

#include "vm/heap.h"

@@ -1904,4 +1905,4 @@ void Disassembler::DecodeInstruction(char* hex_buffer,

} // namespace dart

-#endif // defined TARGET_ARCH_IA32

+#endif // defined(TARGET_ARCH_IA32) && !defined(DART_PRECOMPILED_RUNTIME)

« no previous file with comments | « runtime/vm/disassembler_arm64.cc ('k') | runtime/vm/disassembler_x64.cc » ('j') | no next file with comments »