Issue 2994853002: Use single logger for AnalyzerWorkerLoop and BuildMode instances.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2994853002: Use single logger for AnalyzerWorkerLoop and BuildMode instances. (Closed)

Created:
3 years, 4 months ago by scheglov

Modified:
3 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Use single logger for AnalyzerWorkerLoop and BuildMode instances. I might need to pass this instance into worker level caches, which we will add to improve workers performance. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9475c47db140a805958ba3ccbab628378f1afd08

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -34 lines)			Patch
	M	pkg/analyzer_cli/lib/src/build_mode.dart	View		5 chunks	+40 lines, -34 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 4 months ago (2017-08-11 15:15:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9475c47db140a805958ba3ccbab628378f1afd08 (presubmit successful).