Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2994813002: Fix broken test: closed_world2 test still uses rasta (Closed)

Created:
3 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 4 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix broken test: closed_world2 test still uses rasta R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/5aae972f642c21e7663a5078377a820ed61b3d1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M pkg/compiler/lib/src/kernel/kernel.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
It doesn't seem worth it to add too much more here, we should hopefully soon ...
3 years, 4 months ago (2017-08-09 23:20:16 UTC) #1
sra1
lgtm
3 years, 4 months ago (2017-08-09 23:22:02 UTC) #2
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-08-09 23:22:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5aae972f642c21e7663a5078377a820ed61b3d1e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698