Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2994753002: Prepare all unlinked units before linking. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prepare all unlinked units before linking. This change expects that build mode is always hermetic, i.e. the all unlinked units that are used for linking are given us as inputs. We need to separate computing unlinked units from linking, because linking is synchronous, and access to unlinked units will becore asynchronous when we switch to using Analysis Driver. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ce4f0d40a34928625994edaf6180038b3a5efdb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -60 lines) Patch
M pkg/analyzer_cli/lib/src/build_mode.dart View 5 chunks +63 lines, -60 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 4 months ago (2017-08-08 15:44:39 UTC) #1
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-08-08 16:08:45 UTC) #2
Paul Berry
lgtm
3 years, 4 months ago (2017-08-08 16:36:08 UTC) #3
scheglov
3 years, 4 months ago (2017-08-08 16:37:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce4f0d40a34928625994edaf6180038b3a5efdb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698