Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2994723003: Add analysis_server_client without analysis_server (Closed)

Created:
3 years, 4 months ago by maxkim
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Homepage fix #

Total comments: 3

Patch Set 3 : feedback fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -0 lines) Patch
M .packages View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analysis_server_client/CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/analysis_server_client/LICENSE View 1 chunk +26 lines, -0 lines 0 comments Download
A pkg/analysis_server_client/README.md View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/analysis_server_client/lib/analysis_server_client.dart View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
A pkg/analysis_server_client/pubspec.yaml View 1 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/analysis_server_client/test/analysis_server_client_test.dart View 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
maxkim
3 years, 4 months ago (2017-08-08 21:02:11 UTC) #3
maxkim
3 years, 4 months ago (2017-08-08 21:04:21 UTC) #5
scheglov
I don't have context for this change.
3 years, 4 months ago (2017-08-08 21:06:00 UTC) #6
maxkim
On 2017/08/08 21:06:00, scheglov wrote: > I don't have context for this change. This is ...
3 years, 4 months ago (2017-08-08 21:12:46 UTC) #7
scheglov
The code lgtm. But I think Brian should also take a look. https://codereview.chromium.org/2994723003/diff/20001/pkg/analysis_server_client/lib/analysis_server_client.dart File pkg/analysis_server_client/lib/analysis_server_client.dart ...
3 years, 4 months ago (2017-08-08 21:18:56 UTC) #8
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-08-08 21:38:08 UTC) #9
maxkim
3 years, 4 months ago (2017-08-08 21:57:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4e42dbc1f964f034d67fc93f65271343275d83c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698