common/proto/milo/annotations.proto - Issue 2994593004: [annotee] add SOURCE_MANIFEST annotation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/proto/milo/annotations.proto

Issue 2994593004: [annotee] add SOURCE_MANIFEST annotation. (Closed)

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: common/proto/milo/annotations.proto

diff --git a/common/proto/milo/annotations.proto b/common/proto/milo/annotations.proto

index b9bfe53608b457464aeba06dc197da12dd7e376c..9a82d7f83aa476a0d177986c31566cfb7d113782 100644

--- a/common/proto/milo/annotations.proto

+++ b/common/proto/milo/annotations.proto

@@ -151,7 +151,9 @@ message Step {

// Future hashes which match will not be loaded from the url, but will be

// assumed to be identical. If the sha256 doesn't match the data at the URL,

// Milo may render this build with the wrong manifest.

- string sha256 = 2;

+ //

+ // This is the raw sha256, so it should be exactly 32 bytes.

+ bytes sha256 = 2;

}

// Maps the name of the Manifest, e.g. UNPATCHED, INFRA, etc. to the