Handle migration status entries into split up status files.

Handle migration status entries into split up status files.

R=jcollins@google.com

Committed: https://github.com/dart-lang/sdk/commit/6b7819ec5aaeaca8c2e9d993c3a74d5b22c08c6d

[Bob Nystrom, 2017-08-04 06:15:17]

rnystrom@google.com changed reviewers:
+ jcollins@google.com, whesse@google.com

[Bob Nystrom, 2017-08-04 06:15:18]

This gets the migration tool handling migrating into a series of split status
files a la https://codereview.chromium.org/2993043002/.

I need to coordinate landing this with splitting up the corelib status file but
I thought it would be cleanest to send this out as its own patch and do the
corelib migration on Friday so I could pick up any last minute changes to
corelib_2.status before I split it up.

[jcollins, 2017-08-04 16:55:56]

LGTM

https://codereview.chromium.org/2994573002/diff/1/tools/migration/lib/src/edi...
File tools/migration/lib/src/editable_status_file.dart (right):

https://codereview.chromium.org/2994573002/diff/1/tools/migration/lib/src/edi...
tools/migration/lib/src/editable_status_file.dart:99: void _ensureLines() {
optional: replace this and _lines with a getter for lines that ensures that we
load the _lines in if we haven't already, so that callers don't have to do that.

https://codereview.chromium.org/2994573002/diff/1/tools/migration/lib/src/mig...
File tools/migration/lib/src/migrate_statuses.dart (right):

https://codereview.chromium.org/2994573002/diff/1/tools/migration/lib/src/mig...
tools/migration/lib/src/migrate_statuses.dart:90: bool add(String fromDir,
String header, String entry) {
might be nice to have a comment:  /// Returns true if we were able to add the
entry to a single file.

or something.

https://codereview.chromium.org/2994573002/diff/1/tools/migration/lib/src/mig...
tools/migration/lib/src/migrate_statuses.dart:132: for (var path in
listFiles(fromDir, extension: ".statustemp")) {
was this a temporary change?

[Bob Nystrom, 2017-08-04 17:33:02]

Thanks!

https://codereview.chromium.org/2994573002/diff/1/tools/migration/lib/src/edi...
File tools/migration/lib/src/editable_status_file.dart (right):

https://codereview.chromium.org/2994573002/diff/1/tools/migration/lib/src/edi...
tools/migration/lib/src/editable_status_file.dart:99: void _ensureLines() {
On 2017/08/04 16:55:56, jcollins wrote:
> optional: replace this and _lines with a getter for lines that ensures that we
> load the _lines in if we haven't already, so that callers don't have to do
that.

Good idea, done.

https://codereview.chromium.org/2994573002/diff/1/tools/migration/lib/src/mig...
File tools/migration/lib/src/migrate_statuses.dart (right):

https://codereview.chromium.org/2994573002/diff/1/tools/migration/lib/src/mig...
tools/migration/lib/src/migrate_statuses.dart:90: bool add(String fromDir,
String header, String entry) {
On 2017/08/04 16:55:56, jcollins wrote:
> might be nice to have a comment:  /// Returns true if we were able to add the
> entry to a single file.
> 
> or something.

Done.

https://codereview.chromium.org/2994573002/diff/1/tools/migration/lib/src/mig...
tools/migration/lib/src/migrate_statuses.dart:132: for (var path in
listFiles(fromDir, extension: ".statustemp")) {
On 2017/08/04 16:55:56, jcollins wrote:
> was this a temporary change?

Oops, yes! Fixed.

[Bob Nystrom, 2017-08-04 20:49:33]

Description was changed from

==========
Handle migration status entries into split up status files.
==========

to

==========
Handle migration status entries into split up status files.

R=jcollins@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6b7819ec5aaeaca8c2e9d993c3a74d5b22c08c6d
==========

[Bob Nystrom, 2017-08-04 20:49:35]

Committed patchset #3 (id:40001) manually as
6b7819ec5aaeaca8c2e9d993c3a74d5b22c08c6d (presubmit successful).