Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2994543002: Migrated test block 13 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 13 to Dart 2.0. Removed list_index_of2_test as it shouldn't be valid in Dart 2.0. BUG= R=jcollins@google.com, rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/b1bca14dabb5e3ec0148d23302924b449a09bf86

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address Bob's nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1561 lines) Patch
M tests/corelib/corelib.status View 1 3 chunks +0 lines, -21 lines 0 comments Download
D tests/corelib/linked_hash_map_from_iterables_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/corelib/linked_hash_map_test.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D tests/corelib/list_as_map_test.dart View 1 chunk +0 lines, -96 lines 0 comments Download
D tests/corelib/list_contains_argument_order_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/corelib/list_filled_type_argument_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/corelib/list_first_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/corelib/list_fixed_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/corelib/list_for_each_test.dart View 1 chunk +0 lines, -67 lines 0 comments Download
D tests/corelib/list_growable_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/corelib/list_index_of2_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/corelib/list_index_of_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/corelib/list_insert_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 4 chunks +17 lines, -0 lines 0 comments Download
A + tests/corelib_2/linked_hash_map_from_iterables_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/linked_hash_map_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_as_map_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_contains_argument_order_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/corelib_2/list_fill_range_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_filled_type_argument_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_first_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_fixed_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_for_each_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_get_range_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_growable_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_index_of_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_insert_all_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_insert_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 2 chunks +0 lines, -5 lines 0 comments Download
M tests/corelib_strong/corelib_strong_kernel.status View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/corelib_strong/linked_hash_map_from_iterables_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/corelib_strong/linked_hash_map_test.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D tests/corelib_strong/list_as_map_test.dart View 1 chunk +0 lines, -96 lines 0 comments Download
D tests/corelib_strong/list_contains_argument_order_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/corelib_strong/list_fill_range_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D tests/corelib_strong/list_filled_type_argument_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/corelib_strong/list_first_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/corelib_strong/list_fixed_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/corelib_strong/list_for_each_test.dart View 1 chunk +0 lines, -67 lines 0 comments Download
D tests/corelib_strong/list_get_range_test.dart View 1 chunk +0 lines, -82 lines 0 comments Download
D tests/corelib_strong/list_growable_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/corelib_strong/list_index_of2_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/corelib_strong/list_index_of_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/corelib_strong/list_insert_all_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D tests/corelib_strong/list_insert_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bkonyi
3 years, 4 months ago (2017-08-03 20:46:27 UTC) #2
Bob Nystrom
lgtm https://codereview.chromium.org/2994543002/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (left): https://codereview.chromium.org/2994543002/diff/1/tests/corelib/corelib.status#oldcode39 tests/corelib/corelib.status:39: [ $compiler == dart2js && $runtime == chromeOnAndroid ...
3 years, 4 months ago (2017-08-04 15:45:38 UTC) #3
jcollins
lgtm
3 years, 4 months ago (2017-08-04 17:00:45 UTC) #4
bkonyi
https://codereview.chromium.org/2994543002/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (left): https://codereview.chromium.org/2994543002/diff/1/tests/corelib/corelib.status#oldcode39 tests/corelib/corelib.status:39: [ $compiler == dart2js && $runtime == chromeOnAndroid ] ...
3 years, 4 months ago (2017-08-04 18:14:15 UTC) #5
bkonyi
3 years, 4 months ago (2017-08-04 18:21:29 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b1bca14dabb5e3ec0148d23302924b449a09bf86.

Powered by Google App Engine
This is Rietveld 408576698