Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2994533002: Perform type inference on constructor field initializer expressions. (Closed)

Created:
3 years, 4 months ago by Paul Berry
Modified:
3 years, 4 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Perform type inference on constructor field initializer expressions. Fixes #30251 R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/57d71479e1aa24dc61c102c3dfbc368a87339c9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -3 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/ast_builder.status View 2 chunks +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/bug30251.dart View 1 chunk +15 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/bug30251.dart.direct.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/bug30251.dart.outline.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/bug30251.dart.strong.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_explicit.dart View 1 chunk +15 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_explicit.dart.direct.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_explicit.dart.outline.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_explicit.dart.strong.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_implicit.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_implicit.dart.direct.expect View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_implicit.dart.outline.expect View 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_context_implicit.dart.strong.expect View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_parameter.dart View 1 chunk +15 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_parameter.dart.direct.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_parameter.dart.outline.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/field_initializer_parameter.dart.strong.expect View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
I only need a review from one of you.
3 years, 4 months ago (2017-08-03 20:34:02 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-08-03 20:51:26 UTC) #3
Paul Berry
3 years, 4 months ago (2017-08-03 20:54:41 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
57d71479e1aa24dc61c102c3dfbc368a87339c9e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698