Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2994523002: Filter tests for limited ints in DDC mode (Closed)

Created:
3 years, 4 months ago by alexmarkov
Modified:
3 years, 4 months ago
Reviewers:
bkonyi, zra
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Filter tests for limited ints in DDC mode These tests requires custom DartVM option --limit-ints-to-64-bits and they can't be run through dart2js or dartdevc, so they are filtered in .status file. R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/49819ea5cd2f69ecf1e243177aa44d6bfea39ea3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/corelib_2/corelib_2.status View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
alexmarkov
3 years, 4 months ago (2017-08-03 18:12:52 UTC) #2
bkonyi
lgtm
3 years, 4 months ago (2017-08-03 18:22:11 UTC) #3
alexmarkov
3 years, 4 months ago (2017-08-03 18:22:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49819ea5cd2f69ecf1e243177aa44d6bfea39ea3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698