Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 299443018: Set AppLocale global preference on network screen. (Closed)

Created:
6 years, 7 months ago by Alexander Alekseev
Modified:
6 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Set AppLocale global preference on network screen. There is no device owner during OOBE, so owner settings are not saved, but language setting should be stored. BUG=chrome-os-partner:27284 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexander Alekseev
Please review.
6 years, 7 months ago (2014-05-23 18:26:34 UTC) #1
Nikita (slow)
lgtm
6 years, 7 months ago (2014-05-23 19:25:38 UTC) #2
Alexander Alekseev
The CQ bit was checked by alemate@chromium.org
6 years, 7 months ago (2014-05-23 19:31:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/299443018/1
6 years, 7 months ago (2014-05-23 19:32:57 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 01:15:12 UTC) #5
Message was sent while issue was closed.
Change committed as 272666

Powered by Google App Engine
This is Rietveld 408576698