Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 299443014: Add a UseCounter for CSSCharsetRule.encoding (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
CC:
blink-reviews, arv+blink, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis, watchdog-blink-watchlist_google.com, rune+blink
Visibility:
Public.

Description

Add a UseCounter for CSSCharsetRule.encoding This is by request from Simon Pieters, editor of the CSSOM spec, in order to investige if getting rid of the CSSCharsetRule interface is feasible. This has been discussed on blink-dev: https://groups.google.com/a/chromium.org/d/msg/blink-dev/bWgRZOZKmbk/LZWpPb-ZHJUJ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/css/CSSCharsetRule.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
philipj_slow
6 years, 7 months ago (2014-05-23 12:44:19 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-23 12:55:05 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-05-23 13:00:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/299443014/1
6 years, 7 months ago (2014-05-23 13:01:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 19:02:38 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 20:25:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/8972)
6 years, 7 months ago (2014-05-23 20:25:51 UTC) #7
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-05-23 21:45:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/299443014/1
6 years, 7 months ago (2014-05-23 21:45:41 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 22:38:23 UTC) #10
Message was sent while issue was closed.
Change committed as 174724

Powered by Google App Engine
This is Rietveld 408576698