Add keyboard shortcuts in Files.app to open inspector.

Add keyboard shortcuts in Files.app to open inspector.

This CL adds following keyboard shortcuts for debugging Files.app.

* Ctrl+Shift+I: Open inspector
* Ctrl+Shift+J: Open inspector and focus to console.
* Ctrl+Shift+C: Open inspector and start element inspection.
* Ctrl+Shift+B: Open inspector for the background page.

BUG=280551
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272931

[fukino, 2014-05-23 04:41:27]

@kinaba: PTAL at chrome/browser/chromeos/extensions/file_manager/*
@hirono: PTAL at ui/file_manager/file_manager/foreground/js/file_manager.js

[hirono, 2014-05-23 04:50:08]

https://codereview.chromium.org/299443009/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/file_browser_private.idl (right):

https://codereview.chromium.org/299443009/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/file_browser_private.idl:766: static void
openInspector(DOMString option);
Why don't you use enum instead of string?

https://codereview.chromium.org/299443009/diff/20001/extensions/browser/exten...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/299443009/diff/20001/extensions/browser/exten...
extensions/browser/extension_function_histogram_value.h:837:
FILEBROWSERPRIVATE_OPENINSPECTOR,
Please run tools/metrics/histograms/update_extension_functions.py to update
histograms.xml,

https://codereview.chromium.org/299443009/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/299443009/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:2949: case
'Ctrl-Shift-73':  // Ctrl + Shift + I
Please use command which is a common way to add actions to Files.app.
Zoom shortcuts also uses it.

https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/fi...

[fukino, 2014-05-23 06:16:28]

hirono san, thank you for comments!
Now I use enum for inspection types, use commands to handle shortcuts, and
histgrams.xml is up-to-date.

https://codereview.chromium.org/299443009/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/file_browser_private.idl (right):

https://codereview.chromium.org/299443009/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/file_browser_private.idl:766: static void
openInspector(DOMString option);
On 2014/05/23 04:50:08, hirono wrote:
> Why don't you use enum instead of string?

Done.

https://codereview.chromium.org/299443009/diff/20001/extensions/browser/exten...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/299443009/diff/20001/extensions/browser/exten...
extensions/browser/extension_function_histogram_value.h:837:
FILEBROWSERPRIVATE_OPENINSPECTOR,
On 2014/05/23 04:50:08, hirono wrote:
> Please run tools/metrics/histograms/update_extension_functions.py to update
> histograms.xml,

Done.

https://codereview.chromium.org/299443009/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/299443009/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:2949: case
'Ctrl-Shift-73':  // Ctrl + Shift + I
On 2014/05/23 04:50:08, hirono wrote:
> Please use command which is a common way to add actions to Files.app.
> Zoom shortcuts also uses it.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/fi...

Done.

[hirono, 2014-05-23 06:21:04]

On 2014/05/23 06:16:28, fukino wrote:
> hirono san, thank you for comments!
> Now I use enum for inspection types, use commands to handle shortcuts, and
> histgrams.xml is up-to-date.
> 
>
https://codereview.chromium.org/299443009/diff/20001/chrome/common/extensions...
> File chrome/common/extensions/api/file_browser_private.idl (right):
> 
>
https://codereview.chromium.org/299443009/diff/20001/chrome/common/extensions...
> chrome/common/extensions/api/file_browser_private.idl:766: static void
> openInspector(DOMString option);
> On 2014/05/23 04:50:08, hirono wrote:
> > Why don't you use enum instead of string?
> 
> Done.
> 
>
https://codereview.chromium.org/299443009/diff/20001/extensions/browser/exten...
> File extensions/browser/extension_function_histogram_value.h (right):
> 
>
https://codereview.chromium.org/299443009/diff/20001/extensions/browser/exten...
> extensions/browser/extension_function_histogram_value.h:837:
> FILEBROWSERPRIVATE_OPENINSPECTOR,
> On 2014/05/23 04:50:08, hirono wrote:
> > Please run tools/metrics/histograms/update_extension_functions.py to update
> > histograms.xml,
> 
> Done.
> 
>
https://codereview.chromium.org/299443009/diff/20001/ui/file_manager/file_man...
> File ui/file_manager/file_manager/foreground/js/file_manager.js (right):
> 
>
https://codereview.chromium.org/299443009/diff/20001/ui/file_manager/file_man...
> ui/file_manager/file_manager/foreground/js/file_manager.js:2949: case
> 'Ctrl-Shift-73':  // Ctrl + Shift + I
> On 2014/05/23 04:50:08, hirono wrote:
> > Please use command which is a common way to add actions to Files.app.
> > Zoom shortcuts also uses it.
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/fi...
> 
> Done.

LGTM! Thank you!

[yoshiki, 2014-05-23 06:22:15]

https://codereview.chromium.org/299443009/diff/80001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
(right):

https://codereview.chromium.org/299443009/diff/80001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc:475:
NOTREACHED();
nit: please set an error with SetError() method.

[fukino, 2014-05-23 06:54:31]

Thanks! I placed SetError() on unexpected path.

https://codereview.chromium.org/299443009/diff/80001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
(right):

https://codereview.chromium.org/299443009/diff/80001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc:475:
NOTREACHED();
On 2014/05/23 06:22:16, yoshiki wrote:
> nit: please set an error with SetError() method.

Done.

[yoshiki, 2014-05-23 06:56:54]

lgtm

[kinaba, 2014-05-25 15:38:54]

lgtm

[fukino, 2014-05-26 04:49:47]

@benwells - PTAL at IDL file. (file_browser_private.idl)
@asvintkine - PTAL at histograms. (histogram.xml,
extension_function_histogram_value.h)
@kinaba - Please take a look at pravate_api_misc.cc again. I removed the flag
check based on the agreement on the issue tracker.

[Alexei Svitkine (slow), 2014-05-26 16:40:23]

lgtm

[benwells, 2014-05-27 03:26:37]

lgtm

[kinaba, 2014-05-27 04:25:33]

lgtm

[fukino, 2014-05-27 04:55:28]

Thank you all!

[fukino, 2014-05-27 04:57:12]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-05-27 04:57:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fukino@chromium.org/299443009/140001

[commit-bot: I haz the power, 2014-05-27 08:25:58]

Change committed as 272931