Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 299443005: Don't try to remove xcodebuild directory on Windows. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Don't try to remove xcodebuild directory on Windows. make.py is a python script to be run *only* on Windows and thus xcodebuild directory should not exist there. If we never create it on Windows, then why should we try to remove something we don't create there? R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=14846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M make.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Is this OK?
6 years, 7 months ago (2014-05-21 21:47:08 UTC) #1
epoger
LGTM (It's harmless either way)
6 years, 7 months ago (2014-05-21 21:55:29 UTC) #2
tfarina
6 years, 7 months ago (2014-05-22 15:54:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14846 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698