Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: components/password_manager/core/browser/login_database.h

Issue 299443002: Password Login Database: report correct changes from UpdateLogin(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added UpdateNonexistentLogin tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/login_database.h
diff --git a/components/password_manager/core/browser/login_database.h b/components/password_manager/core/browser/login_database.h
index cfd7db683bbea9f326ebb1a33af55136d2eb288c..8fcf8469b17e4bfe64a0db0dcd480a4648fcfc9b 100644
--- a/components/password_manager/core/browser/login_database.h
+++ b/components/password_manager/core/browser/login_database.h
@@ -39,9 +39,11 @@ class LoginDatabase {
// primary key columns contain the values associated with the removed form.
PasswordStoreChangeList AddLogin(const autofill::PasswordForm& form);
- // Updates remembered password form. Returns true on success and sets
- // items_changed (if non-NULL) to the number of logins updated.
- bool UpdateLogin(const autofill::PasswordForm& form, int* items_changed);
+ // Updates existing password form. Returns the list of applied changes
+ // ({}, {UPDATE}). The password is looked up by the tuple {origin,
+ // username_element, username_value, password_element, signon_realm}.
+ // These columns stay intact.
+ PasswordStoreChangeList UpdateLogin(const autofill::PasswordForm& form);
// Removes |form| from the list of remembered password forms.
bool RemoveLogin(const autofill::PasswordForm& form);

Powered by Google App Engine
This is Rietveld 408576698