chrome/browser/password_manager/password_store_x.cc - Issue 299443002: Password Login Database: report correct changes from UpdateLogin().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_x.cc

Issue 299443002: Password Login Database: report correct changes from UpdateLogin(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added UpdateNonexistentLogin tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/password_store_x.cc

diff --git a/chrome/browser/password_manager/password_store_x.cc b/chrome/browser/password_manager/password_store_x.cc

index b571db7137a385001307611a2154bff7e85eb523..8a6fc746d4f276041f6d66dadd272219c1f7412b 100644

--- a/chrome/browser/password_manager/password_store_x.cc

+++ b/chrome/browser/password_manager/password_store_x.cc

@@ -65,8 +65,7 @@ PasswordStoreChangeList PasswordStoreX::UpdateLoginImpl(

const PasswordForm& form) {

CheckMigration();

PasswordStoreChangeList changes;

- if (use_native_backend() && backend_->UpdateLogin(form)) {

- changes.push_back(PasswordStoreChange(PasswordStoreChange::UPDATE, form));

+ if (use_native_backend() && backend_->UpdateLogin(form, &changes)) {

allow_fallback_ = false;

} else if (allow_default_store()) {

changes = PasswordStoreDefault::UpdateLoginImpl(form);