chrome/browser/password_manager/native_backend_kwallet_x.h - Issue 299443002: Password Login Database: report correct changes from UpdateLogin().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x.h

Issue 299443002: Password Login Database: report correct changes from UpdateLogin(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added UpdateNonexistentLogin tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/native_backend_kwallet_x.h

diff --git a/chrome/browser/password_manager/native_backend_kwallet_x.h b/chrome/browser/password_manager/native_backend_kwallet_x.h

index 1fab1859774464c751a6f53537dd49e3c9dcbd5a..3555815a9b3aa747d55c39780272fa14d88b54fb 100644

--- a/chrome/browser/password_manager/native_backend_kwallet_x.h

+++ b/chrome/browser/password_manager/native_backend_kwallet_x.h

@@ -42,7 +42,9 @@ class NativeBackendKWallet : public PasswordStoreX::NativeBackend {

// Implements NativeBackend interface.

virtual password_manager::PasswordStoreChangeList AddLogin(

const autofill::PasswordForm& form) OVERRIDE;

- virtual bool UpdateLogin(const autofill::PasswordForm& form) OVERRIDE;

+ virtual bool UpdateLogin(

+ const autofill::PasswordForm& form,

+ password_manager::PasswordStoreChangeList* changes) OVERRIDE;

virtual bool RemoveLogin(const autofill::PasswordForm& form) OVERRIDE;

virtual bool RemoveLoginsCreatedBetween(

const base::Time& delete_begin, const base::Time& delete_end) OVERRIDE;