components/password_manager/core/browser/password_store_default.cc - Issue 299443002: Password Login Database: report correct changes from UpdateLogin().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default.cc

Issue 299443002: Password Login Database: report correct changes from UpdateLogin(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respect primary key in the UpdateLogin() Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_store_default.cc

diff --git a/components/password_manager/core/browser/password_store_default.cc b/components/password_manager/core/browser/password_store_default.cc

index fe68f4a445c5aa76edb0dac5a7d591fae41e5044..92cab5abd9300fd947ac34268664a19b2185a1b5 100644

--- a/components/password_manager/core/browser/password_store_default.cc

+++ b/components/password_manager/core/browser/password_store_default.cc

@@ -40,10 +40,7 @@ PasswordStoreChangeList PasswordStoreDefault::AddLoginImpl(

PasswordStoreChangeList PasswordStoreDefault::UpdateLoginImpl(

const PasswordForm& form) {

DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread());

- PasswordStoreChangeList changes;

- if (login_db_->UpdateLogin(form, NULL))

- changes.push_back(PasswordStoreChange(PasswordStoreChange::UPDATE, form));

- return changes;

+ return login_db_->UpdateLogin(form);

}

PasswordStoreChangeList PasswordStoreDefault::RemoveLoginImpl(