Password Login Database: report correct changes from UpdateLogin().

chrome/browser/password_manager/native_backend_kwallet_x.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/native_backend_kwallet_x.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 283 matching lines @@
   changes.push_back(password_manager::PasswordStoreChange(
       password_manager::PasswordStoreChange::ADD, form));
 
   bool ok = SetLoginsList(forms.get(), form.signon_realm, wallet_handle);
   if (!ok)
     changes.clear();
 
   return changes;
 }
 
-bool NativeBackendKWallet::UpdateLogin(const PasswordForm& form) {
+bool NativeBackendKWallet::UpdateLogin(
+    const PasswordForm& form,
+    password_manager::PasswordStoreChangeList* changes) {
+  DCHECK(changes);
+  changes->clear();
   int wallet_handle = WalletHandle();
   if (wallet_handle == kInvalidKWalletHandle)
     return false;
 
-  PasswordFormList forms;
-  GetLoginsList(&forms, form.signon_realm, wallet_handle);
+  ScopedVector<autofill::PasswordForm> forms;
+  GetLoginsList(&forms.get(), form.signon_realm, wallet_handle);
 
+  bool updated = false;
   for (size_t i = 0; i < forms.size(); ++i) {
-    if (CompareForms(form, *forms[i], true))
+    if (CompareForms(form, *forms[i], true)) {
       *forms[i] = form;
+      updated = true;
+    }
+  }
+  if (!updated)
+    return true;
+
+  if (SetLoginsList(forms.get(), form.signon_realm, wallet_handle)) {
+    changes->push_back(password_manager::PasswordStoreChange(
+        password_manager::PasswordStoreChange::UPDATE, form));
+    return true;
   }
 
-  bool ok = SetLoginsList(forms, form.signon_realm, wallet_handle);
-
-  STLDeleteElements(&forms);
-  return ok;
+  return false;
 }
 
 bool NativeBackendKWallet::RemoveLogin(const PasswordForm& form) {
   int wallet_handle = WalletHandle();
   if (wallet_handle == kInvalidKWalletHandle)
     return false;
 
   PasswordFormList all_forms;
   GetLoginsList(&all_forms, form.signon_realm, wallet_handle);
 
@@ skipping 591 matching lines @@
   }
 
   return handle;
 }
 
 std::string NativeBackendKWallet::GetProfileSpecificFolderName() const {
   // Originally, the folder name was always just "Chrome Form Data".
   // Now we use it to distinguish passwords for different profiles.
   return base::StringPrintf("%s (%d)", kKWalletFolder, profile_id_);
 }