Password Login Database: report correct changes from UpdateLogin().

chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdarg.h>
 
 #include "base/basictypes.h"
 #include "base/prefs/pref_service.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
@@ skipping 538 matching lines @@
     const base::string16 kNewPassword(UTF8ToUTF16("new_b"));
     EXPECT_NE(kOldPassword, kNewPassword);
     new_facebook.password_value = kNewPassword;
     switch (update_type) {
       case UPDATE_BY_UPDATELOGIN:
         BrowserThread::PostTask(
             BrowserThread::DB,
             FROM_HERE,
             base::Bind(base::IgnoreResult(&NativeBackendGnome::UpdateLogin),
                        base::Unretained(&backend),
-                       new_facebook));
+                       new_facebook,
+                       base::Owned(new PasswordStoreChangeList)));
         break;
       case UPDATE_BY_ADDLOGIN:
         BrowserThread::PostTask(
             BrowserThread::DB,
             FROM_HERE,
             base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                        base::Unretained(&backend),
                        new_facebook));
         break;
     }
@@ skipping 155 matching lines @@
 TEST_F(NativeBackendGnomeTest, PSLUpdatingStrictUpdateLogin) {
   CheckPSLUpdate(UPDATE_BY_UPDATELOGIN);
 }
 
 TEST_F(NativeBackendGnomeTest, PSLUpdatingStrictAddLogin) {
   // TODO(vabr): if AddLogin becomes no longer valid for existing logins, then
   // just delete this test.
   CheckPSLUpdate(UPDATE_BY_ADDLOGIN);
 }
 
 TEST_F(NativeBackendGnomeTest, BasicUpdateLogin) {

[Garrett Casto, 2014/05/21 19:14:20]

Would you mind adding a test that calling UpdateLogin() when there are no
matching forms doesn't add the form to the database? Seems like a hole in the
testing coverage.

[vasilii, 2014/05/22 11:38:14]

Done.

   NativeBackendGnome backend(42);
   backend.Init();
 
   // First add google login.
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                  base::Unretained(&backend), form_google_));
 
   RunBothThreads();
 
   PasswordForm new_form_google(form_google_);
   new_form_google.times_used = 1;
   new_form_google.action = GURL("http://www.google.com/different/login");
 
   EXPECT_EQ(1u, mock_keyring_items.size());
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome-42");
 
   // Update login
+  PasswordStoreChangeList changes;
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult(&NativeBackendGnome::UpdateLogin),
-                 base::Unretained(&backend), new_form_google));
+                 base::Unretained(&backend),
+                 new_form_google,
+                 base::Unretained(&changes)));
 
   RunBothThreads();
 
+  ASSERT_EQ(1u, changes.size());
+  EXPECT_EQ(PasswordStoreChange::UPDATE, changes.front().type());
+  EXPECT_EQ(new_form_google, changes.front().form());
   EXPECT_EQ(1u, mock_keyring_items.size());
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], new_form_google, "chrome-42");
 }
 
 TEST_F(NativeBackendGnomeTest, BasicRemoveLogin) {
   NativeBackendGnome backend(42);
   backend.Init();
 
   BrowserThread::PostTask(
@@ skipping 118 matching lines @@
   // Quick check that we got two results back.
   EXPECT_EQ(2u, form_list.size());
   STLDeleteElements(&form_list);
 
   EXPECT_EQ(1u, mock_keyring_items.size());
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome-42");
 }
 
 // TODO(mdm): add more basic tests here at some point.