Issue 2994383003: Avoid crash for type variables in mixed in fields.

Issue 2994383003: Avoid crash for type variables in mixed in fields. (Closed)

Created:
3 years, 4 months ago by Johnni Winther

Modified:
3 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Avoid crash for type variables in mixed in fields. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/9b87beb184b8ddc70246cb3b9e8279faec9fc339

Patch Set 1 #

Total comments: 2

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -43 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View	5 chunks	+51 lines, -36 lines	2 comments	Download
A	tests/language/closure_in_field_test.dart	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/2994383003/diff/1/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/2994383003/diff/1/pkg/compiler/lib/src/ssa/builder.dart#newcode993 pkg/compiler/lib/src/ssa/builder.dart:993: includeTypeVariables(member); any reason why this shouldn't be done ...

3 years, 4 months ago (2017-08-17 18:44:50 UTC) #3

Johnni Winther

Committed patchset #1 (id:1) manually as 9b87beb184b8ddc70246cb3b9e8279faec9fc339 (presubmit successful).

3 years, 4 months ago (2017-08-18 13:34:00 UTC) #5

Johnni Winther

3 years, 4 months ago (2017-08-18 14:09:34 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/2994383003/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/2994383003/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:993: includeTypeVariables(member);
On 2017/08/17 18:44:50, Siggi Cherem (dart-lang) wrote:
> any reason why this shouldn't be done in buildFieldInitializers?

[inlinedFrom] accesses the missing values before the call to
[buildFieldInitializers]

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages