Migrating block 50, first commit, after tool has run

Migrating block 59, first commit, after tool has run.

There were tests that tested only checked mode, having their name on the form xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added to the status file.

R=rnystrom@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/706d4231ea40a41dd80409c3d835fd8ec5fb5dc3
Committed: https://github.com/dart-lang/sdk/commit/da2397acacd46a51e6119d76accd7d4085f31846
Committed: https://github.com/dart-lang/sdk/commit/ef4c7d33b4058962c379052b89ed60dafa1c88a7

[mkroghj, 2017-08-17 12:05:25]

Description was changed from

==========
Migrating block 59, first commit, after tool has run
==========

to

==========
Migrating block 59, first commit, after tool has run.

There were tests that tested only checked mode, having their name on the form
xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added
to the status file.
==========

[mkroghj, 2017-08-17 12:31:00]

mkroghj@google.com changed reviewers:
+ rnystrom@google.com, whesse@google.com

[mkroghj, 2017-08-17 12:32:40]

ptal

[Bill Hesse, 2017-08-17 13:23:25]

LGTM, wait for Bob as well.

https://codereview.chromium.org/2994383002/diff/40001/tests/language_2/langua...
File tests/language_2/language_2.status (right):

https://codereview.chromium.org/2994383002/diff/40001/tests/language_2/langua...
tests/language_2/language_2.status:33: compile_time_constant_k_test/03:
MissingCompileTimeError # Requires strong mode
This comment is ok, since it is needed everywhere.

https://codereview.chromium.org/2994383002/diff/40001/tests/language_2/langua...
File tests/language_2/language_2_dartdevc.status (right):

https://codereview.chromium.org/2994383002/diff/40001/tests/language_2/langua...
tests/language_2/language_2_dartdevc.status:117: compile_time_constant_a_test:
RuntimeError # Allows mutating const map.
File an issue and put issue number there.

https://codereview.chromium.org/2994383002/diff/40001/tests/language_2/langua...
File tests/language_2/language_2_kernel.status (right):

https://codereview.chromium.org/2994383002/diff/40001/tests/language_2/langua...
tests/language_2/language_2_kernel.status:170: compile_time_constant_c_test/02:
MissingCompileTimeError # KernelVM bug: Constant evaluation.
Do not put comments in the status files, only links to issue numbers.

[Bob Nystrom, 2017-08-23 21:56:55]

Sorry for the long delay. I was watching the eclipse.

Thanks for getting involved!

https://codereview.chromium.org/2994383002/diff/60001/tests/language_2/compil...
File tests/language_2/compile_time_constant_static2_test.dart (right):

https://codereview.chromium.org/2994383002/diff/60001/tests/language_2/compil...
tests/language_2/compile_time_constant_static2_test.dart:20: const a6 = const
A.a6('foo'); //# 06: compile-time error
Maybe I'm missing something obvious, but why are these compile errors?

https://codereview.chromium.org/2994383002/diff/60001/tests/language_2/compil...
File tests/language_2/compile_time_constant_static5_test.dart (right):

https://codereview.chromium.org/2994383002/diff/60001/tests/language_2/compil...
tests/language_2/compile_time_constant_static5_test.dart:39: final V x = const
C.d(); //# 10: static type warning
These should all become "compile-time error" too. In Dart 2.0, there is no
checked more or static type warnings.

https://codereview.chromium.org/2994383002/diff/60001/tests/language_2/langua...
File tests/language_2/language_2_dartdevc.status (right):

https://codereview.chromium.org/2994383002/diff/60001/tests/language_2/langua...
tests/language_2/language_2_dartdevc.status:117: # compile_time_constant_a_test:
RuntimeError # Issue 30526
Was this supposed to be commented out?

[mkroghj, 2017-08-24 07:55:15]

ptal

https://codereview.chromium.org/2994383002/diff/60001/tests/language_2/compil...
File tests/language_2/compile_time_constant_static2_test.dart (right):

https://codereview.chromium.org/2994383002/diff/60001/tests/language_2/compil...
tests/language_2/compile_time_constant_static2_test.dart:20: const a6 = const
A.a6('foo'); //# 06: compile-time error
On 2017/08/23 21:56:54, Bob Nystrom wrote:
> Maybe I'm missing something obvious, but why are these compile errors?

This is because the named constructor tries to set the final field int x to a
string.

[Bob Nystrom, 2017-08-24 16:18:25]

LGTM!

https://codereview.chromium.org/2994383002/diff/60001/tests/language_2/compil...
File tests/language_2/compile_time_constant_static2_test.dart (right):

https://codereview.chromium.org/2994383002/diff/60001/tests/language_2/compil...
tests/language_2/compile_time_constant_static2_test.dart:20: const a6 = const
A.a6('foo'); //# 06: compile-time error
On 2017/08/24 07:55:15, mkroghj wrote:
> On 2017/08/23 21:56:54, Bob Nystrom wrote:
> > Maybe I'm missing something obvious, but why are these compile errors?
> 
> This is because the named constructor tries to set the final field int x to a
> string.
> 

Oh, duh. Thanks. :)

[mkroghj, 2017-08-25 10:10:25]

Description was changed from

==========
Migrating block 59, first commit, after tool has run.

There were tests that tested only checked mode, having their name on the form
xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added
to the status file.
==========

to

==========
Migrating block 59, first commit, after tool has run.

There were tests that tested only checked mode, having their name on the form
xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added
to the status file.

R=rnystrom@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/706d4231ea40a41dd80409c3d835fd8ec5fb5dc3
==========

[mkroghj, 2017-08-25 10:10:27]

Committed patchset #6 (id:100001) manually as
706d4231ea40a41dd80409c3d835fd8ec5fb5dc3 (presubmit successful).

[mkroghj, 2017-08-25 11:06:20]

Description was changed from

==========
Migrating block 59, first commit, after tool has run.

There were tests that tested only checked mode, having their name on the form
xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added
to the status file.

R=rnystrom@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/706d4231ea40a41dd80409c3d835fd8ec5fb5dc3
==========

to

==========
Migrating block 59, first commit, after tool has run.

There were tests that tested only checked mode, having their name on the form
xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added
to the status file.

R=rnystrom@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/706d4231ea40a41dd80409c3d835fd8ec5fb5dc3
Committed:
https://github.com/dart-lang/sdk/commit/da2397acacd46a51e6119d76accd7d4085f31846
==========

[mkroghj, 2017-08-25 11:06:21]

Committed patchset #7 (id:120001) manually as
da2397acacd46a51e6119d76accd7d4085f31846.

[mkroghj, 2017-08-25 12:03:42]

Description was changed from

==========
Migrating block 59, first commit, after tool has run.

There were tests that tested only checked mode, having their name on the form
xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added
to the status file.

R=rnystrom@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/706d4231ea40a41dd80409c3d835fd8ec5fb5dc3
Committed:
https://github.com/dart-lang/sdk/commit/da2397acacd46a51e6119d76accd7d4085f31846
==========

to

==========
Migrating block 59, first commit, after tool has run.

There were tests that tested only checked mode, having their name on the form
xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added
to the status file.

R=rnystrom@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/706d4231ea40a41dd80409c3d835fd8ec5fb5dc3
Committed:
https://github.com/dart-lang/sdk/commit/da2397acacd46a51e6119d76accd7d4085f31846
Committed:
https://github.com/dart-lang/sdk/commit/ef4c7d33b4058962c379052b89ed60dafa1c88a7
==========

[mkroghj, 2017-08-25 12:03:44]

Committed patchset #9 (id:160001) manually as
ef4c7d33b4058962c379052b89ed60dafa1c88a7 (presubmit successful).

[mkroghj, 2017-08-30 05:44:27]

Description was changed from

==========
Migrating block 59, first commit, after tool has run.

There were tests that tested only checked mode, having their name on the form
xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added
to the status file.

R=rnystrom@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/706d4231ea40a41dd80409c3d835fd8ec5fb5dc3
Committed:
https://github.com/dart-lang/sdk/commit/da2397acacd46a51e6119d76accd7d4085f31846
Committed:
https://github.com/dart-lang/sdk/commit/ef4c7d33b4058962c379052b89ed60dafa1c88a7
==========

to

==========
Migrating block 59, first commit, after tool has run.

There were tests that tested only checked mode, having their name on the form
xx_checked_xx. Those files have been renamed to static.

We found an issue in the DDC regarding constant maps, the issue has been added
to the status file.

R=rnystrom@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/706d4231ea40a41dd80409c3d835fd8ec5fb5dc3
Committed:
https://github.com/dart-lang/sdk/commit/da2397acacd46a51e6119d76accd7d4085f31846
Committed:
https://github.com/dart-lang/sdk/commit/ef4c7d33b4058962c379052b89ed60dafa1c88a7
==========