Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2994363002: Fix the local variable lookup in the locals handler. (Closed)

Created:
3 years, 4 months ago by Emily Fortuna
Modified:
3 years, 4 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, Johnni Winther, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the local variable lookup in the locals handler. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/09b215a2fd649dc2bdfa32792f49565c018a3db7

Patch Set 1 #

Patch Set 2 : . #

Total comments: 5

Patch Set 3 : status files. #

Patch Set 4 : stephen comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -1001 lines) Patch
M pkg/compiler/lib/src/js_model/closure.dart View 1 2 3 8 chunks +38 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure_visitors.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_model/elements.dart View 1 chunk +10 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_model/locals.dart View 3 chunks +17 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 2 chunks +13 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 6 chunks +28 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 2 10 chunks +11 lines, -58 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 2 7 chunks +3 lines, -9 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 2 19 chunks +23 lines, -92 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 79 chunks +135 lines, -744 lines 0 comments Download
M tests/language_2/language_2_dart2js.status View 1 2 14 chunks +24 lines, -38 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Emily Fortuna
(updating test statuses currently)
3 years, 4 months ago (2017-08-16 19:52:28 UTC) #2
Emily Fortuna
3 years, 4 months ago (2017-08-16 20:11:50 UTC) #3
sra1
L"G"TM https://codereview.chromium.org/2994363002/diff/20001/pkg/compiler/lib/src/js_model/closure.dart File pkg/compiler/lib/src/js_model/closure.dart (right): https://codereview.chromium.org/2994363002/diff/20001/pkg/compiler/lib/src/js_model/closure.dart#newcode347 pkg/compiler/lib/src/js_model/closure.dart:347: final ClassEntity closureClassEntity; JClass makes direction more explict ...
3 years, 4 months ago (2017-08-16 22:25:19 UTC) #4
sra1
lgtm
3 years, 4 months ago (2017-08-16 22:25:34 UTC) #5
Emily Fortuna
https://codereview.chromium.org/2994363002/diff/20001/pkg/compiler/lib/src/js_model/closure.dart File pkg/compiler/lib/src/js_model/closure.dart (right): https://codereview.chromium.org/2994363002/diff/20001/pkg/compiler/lib/src/js_model/closure.dart#newcode347 pkg/compiler/lib/src/js_model/closure.dart:347: final ClassEntity closureClassEntity; On 2017/08/16 22:25:19, sra1 wrote: > ...
3 years, 4 months ago (2017-08-16 22:55:46 UTC) #6
Emily Fortuna
3 years, 4 months ago (2017-08-16 23:08:31 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
09b215a2fd649dc2bdfa32792f49565c018a3db7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698