pkg/compiler/lib/src/ssa/builder_kernel.dart - Issue 2994353002: Fix the locals lookup of variables and partial implementation of boxing of variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2994353002: Fix the locals lookup of variables and partial implementation of boxing of variables.

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/builder_kernel.dart

diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart

index 527e7d66ba4852fc08f2825fc73f0e5e1357de06..4857f2a711bbf31be8614d3b78847f77f366c7bb 100644

--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart

+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart

@@ -2219,7 +2219,10 @@ class KernelSsaGraphBuilder extends ir.Visitor

return;

}

- Local local = localsMap.getLocalVariable(variableGet.variable);

+ Local local = localsMap.getLocalVariable(variableGet.variable,

+ isClosureCallMethod:

+ _elementMap.getMemberDefinition(targetElement).kind ==

+ MemberKind.closureCall);

stack.add(localsHandler.readLocal(local));

}