Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: chrome/browser/bookmarks/enhanced_bookmarks_features.cc

Issue 299433003: Fixed enhanced bookmarks experiment state lost durring previous review. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/enhanced_bookmarks_features.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/enhanced_bookmarks_features.cc
diff --git a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
index c8763f7968d9d36c45675e16ee902905404731fd..5ce9b9aefa09d514ad487f7d910f1034f633b698 100644
--- a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
+++ b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
@@ -55,7 +55,7 @@ bool GetBookmarksExperimentExtensionID(const PrefService* user_prefs,
return false;
}
-void UpdateBookmarksExperimentState(const PrefService* user_prefs,
+void UpdateBookmarksExperimentState(PrefService* user_prefs,
PrefService* local_state,
bool user_signed_in) {
BookmarksExperimentState bookmarks_experiment_state_before =
@@ -111,6 +111,9 @@ void UpdateBookmarksExperimentState(const PrefService* user_prefs,
UMA_HISTOGRAM_ENUMERATION("EnhancedBookmarks.SyncExperimentState",
bookmarks_experiment_new_state,
kBookmarksExperimentEnumSize);
+ user_prefs->SetInteger(
+ sync_driver::prefs::kEnhancedBookmarksExperimentEnabled,
+ bookmarks_experiment_new_state);
if (bookmarks_experiment_state_before != bookmarks_experiment_new_state)
ForceFinchBookmarkExperimentIfNeeded(local_state,
bookmarks_experiment_new_state);
« no previous file with comments | « chrome/browser/bookmarks/enhanced_bookmarks_features.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698