Prepare CrashHandlerHostLinux for move to breakpad component

Prepare CrashHandlerHostLinux for move to breakpad component

To move the linux breakpad files to the component, we first need to
remove all dependencies on chrome/ from the browser side parts.

BUG=247431
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229573

[Nico, 2013-10-19 01:28:45]

lgtm, but please please make the thread creation explicit at the calling site

https://codereview.chromium.org/29943005/diff/1/chrome/browser/chrome_content...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/29943005/diff/1/chrome/browser/chrome_content...
chrome/browser/chrome_content_browser_client.cc:504: process_type, dumps_path,
(getenv(env_vars::kHeadless) == NULL));
no parens for the 3rd param here (compilers usually assume that parens imply
intended assignment)

https://codereview.chromium.org/29943005/diff/1/chrome/browser/crash_handler_...
File chrome/browser/crash_handler_host_linux.cc (left):

https://codereview.chromium.org/29943005/diff/1/chrome/browser/crash_handler_...
chrome/browser/crash_handler_host_linux.cc:452:
ExtensionCrashHandlerHostLinux::ExtensionCrashHandlerHostLinux() {
These classes were weird.

https://codereview.chromium.org/29943005/diff/1/chrome/browser/crash_handler_...
File chrome/browser/crash_handler_host_linux.cc (right):

https://codereview.chromium.org/29943005/diff/1/chrome/browser/crash_handler_...
chrome/browser/crash_handler_host_linux.cc:30: #include
"chrome/app/breakpad_linux_impl.h"
This is for a folllow-up I suppose.

https://codereview.chromium.org/29943005/diff/1/chrome/browser/crash_handler_...
chrome/browser/crash_handler_host_linux.cc:65: // Since instances of
CrashHandlerHostLinux are leaked, it's only destroyed at
s/it's/they are/ :-P

https://codereview.chromium.org/29943005/diff/1/chrome/browser/crash_handler_...
chrome/browser/crash_handler_host_linux.cc:100: uploader_thread_->Start();
Can this stay in a method? Constructors that start threads are not exactly best
practice.

[commit-bot: I haz the power, 2013-10-19 02:24:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/29943005/90001

[jochen (gone - plz use gerrit), 2013-10-19 02:38:35]

https://codereview.chromium.org/29943005/diff/1/chrome/browser/chrome_content...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/29943005/diff/1/chrome/browser/chrome_content...
chrome/browser/chrome_content_browser_client.cc:504: process_type, dumps_path,
(getenv(env_vars::kHeadless) == NULL));
On 2013/10/19 01:28:46, Nico wrote:
> no parens for the 3rd param here (compilers usually assume that parens imply
> intended assignment)

Done.

https://codereview.chromium.org/29943005/diff/1/chrome/browser/crash_handler_...
File chrome/browser/crash_handler_host_linux.cc (right):

https://codereview.chromium.org/29943005/diff/1/chrome/browser/crash_handler_...
chrome/browser/crash_handler_host_linux.cc:30: #include
"chrome/app/breakpad_linux_impl.h"
On 2013/10/19 01:28:46, Nico wrote:
> This is for a folllow-up I suppose.

Right, those files will be moved all together to the component

https://codereview.chromium.org/29943005/diff/1/chrome/browser/crash_handler_...
chrome/browser/crash_handler_host_linux.cc:65: // Since instances of
CrashHandlerHostLinux are leaked, it's only destroyed at
On 2013/10/19 01:28:46, Nico wrote:
> s/it's/they are/ :-P

Done.

https://codereview.chromium.org/29943005/diff/1/chrome/browser/crash_handler_...
chrome/browser/crash_handler_host_linux.cc:100: uploader_thread_->Start();
On 2013/10/19 01:28:46, Nico wrote:
> Can this stay in a method? Constructors that start threads are not exactly
best
> practice.

Done.

[commit-bot: I haz the power, 2013-10-19 04:53:16]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[jochen (gone - plz use gerrit), 2013-10-19 15:57:06]

Committed patchset #2 manually as r229573 (presubmit successful).