Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 29943005: Prepare CrashHandlerHostLinux for move to breakpad component (Closed)

Created:
7 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Prepare CrashHandlerHostLinux for move to breakpad component To move the linux breakpad files to the component, we first need to remove all dependencies on chrome/ from the browser side parts. BUG=247431 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229573

Patch Set 1 #

Total comments: 9

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -201 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 3 chunks +41 lines, -10 lines 0 comments Download
M chrome/browser/crash_handler_host_linux.h View 1 6 chunks +17 lines, -95 lines 0 comments Download
M chrome/browser/crash_handler_host_linux.cc View 1 7 chunks +18 lines, -96 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
7 years, 2 months ago (2013-10-19 01:16:45 UTC) #1
Nico
lgtm, but please please make the thread creation explicit at the calling site https://codereview.chromium.org/29943005/diff/1/chrome/browser/chrome_content_browser_client.cc File ...
7 years, 2 months ago (2013-10-19 01:28:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/29943005/90001
7 years, 2 months ago (2013-10-19 02:24:23 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/29943005/diff/1/chrome/browser/chrome_content_browser_client.cc File chrome/browser/chrome_content_browser_client.cc (right): https://codereview.chromium.org/29943005/diff/1/chrome/browser/chrome_content_browser_client.cc#newcode504 chrome/browser/chrome_content_browser_client.cc:504: process_type, dumps_path, (getenv(env_vars::kHeadless) == NULL)); On 2013/10/19 01:28:46, Nico ...
7 years, 2 months ago (2013-10-19 02:38:35 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-19 04:53:16 UTC) #5
jochen (gone - plz use gerrit)
7 years, 2 months ago (2013-10-19 15:57:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r229573 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698