Limit display of the virtual keyboard to state changes triggered from a user gesture.

content/renderer/render_widget.cc

Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index a64b6184fca82289a2db2d5a25d880a19e28ee4c..6d67b70a2459ad09bcbe373b9b6675813c026f31 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -1195,6 +1195,12 @@ void RenderWidget::OnHandleInputEvent(const blink::WebInputEvent* input_event,
   // of a processed touch end event.
   if (input_event->type == WebInputEvent::TouchEnd && processed)
     UpdateTextInputState(true, true);
+#elif defined(USE_AURA)
+  // Show the virtual keyboard if enabled and a user gesture triggers a focus
+  // change.
+  if (processed && (input_event->type == WebInputEvent::TouchEnd ||
+      input_event->type == WebInputEvent::MouseUp))
+    UpdateTextInputState(true, false);
 #endif
 
   handling_input_event_ = false;
@@ -2497,7 +2503,7 @@ void RenderWidget::UpdateTextInputType() {
   }
 }
 
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) || defined(USE_AURA)
 void RenderWidget::UpdateTextInputState(bool show_ime_if_needed,
                                         bool send_ime_ack) {
   if (handling_ime_event_)
@@ -2528,9 +2534,13 @@ void RenderWidget::UpdateTextInputState(bool show_ime_if_needed,
     p.composition_end = new_info.compositionEnd;
     p.can_compose_inline = new_can_compose_inline;
     p.show_ime_if_needed = show_ime_if_needed;
+#if defined(OS_ANDROID)
     p.require_ack = send_ime_ack;
     if (p.require_ack)
       IncrementOutstandingImeEventAcks();
+#else
+    p.require_ack = false;
+#endif

[Shu Chen, 2014/01/09 04:21:17]

This change is unnecessary if pass send_ime_ack correctly. Pls see my comment at
line 2724.

[kevers, 2014/01/09 15:29:09]

IncrementOutstandingImeEventAcks is Android only. Removing this check requires
exposing other Android specific areas of code cross platform.  With a followup
CL, I would like to phase out of UpdateTextInputTypeChange in favor of
UpdateTextInputStateChange. At that point, we'll simply want to ignore the ack
parameter on non-Android builds. This check keeps the logic localized.

     Send(new ViewHostMsg_TextInputStateChanged(routing_id(), p));
 
     text_input_info_ = new_info;
@@ -2706,7 +2716,7 @@ void RenderWidget::resetInputMethod() {
 void RenderWidget::didHandleGestureEvent(
     const WebGestureEvent& event,
     bool event_cancelled) {
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) || defined(USE_AURA)
   if (event_cancelled)
     return;
   if (event.type == WebInputEvent::GestureTap ||