Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/ui/omnibox/omnibox_view.cc

Issue 29943002: Limit display of the virtual keyboard to state changes triggered from a user gesture. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ash_unittests Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view.h ('k') | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file defines helper functions shared by the various implementations 5 // This file defines helper functions shared by the various implementations
6 // of OmniboxView. 6 // of OmniboxView.
7 7
8 #include "chrome/browser/ui/omnibox/omnibox_view.h" 8 #include "chrome/browser/ui/omnibox/omnibox_view.h"
9 9
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 model_->StopAutocomplete(); 140 model_->StopAutocomplete();
141 } 141 }
142 142
143 bool OmniboxView::IsImeShowingPopup() const { 143 bool OmniboxView::IsImeShowingPopup() const {
144 // Default to claiming that the IME is not showing a popup, since hiding the 144 // Default to claiming that the IME is not showing a popup, since hiding the
145 // omnibox dropdown is a bad user experience when we don't know for sure that 145 // omnibox dropdown is a bad user experience when we don't know for sure that
146 // we have to. 146 // we have to.
147 return false; 147 return false;
148 } 148 }
149 149
150 void OmniboxView::ShowImeIfNeeded() {
151 }
152
150 bool OmniboxView::IsIndicatingQueryRefinement() const { 153 bool OmniboxView::IsIndicatingQueryRefinement() const {
151 // The default implementation always returns false. Mobile ports can override 154 // The default implementation always returns false. Mobile ports can override
152 // this method and implement as needed. 155 // this method and implement as needed.
153 return false; 156 return false;
154 } 157 }
155 158
156 OmniboxView::OmniboxView(Profile* profile, 159 OmniboxView::OmniboxView(Profile* profile,
157 OmniboxEditController* controller, 160 OmniboxEditController* controller,
158 CommandUpdater* command_updater) 161 CommandUpdater* command_updater)
159 : controller_(controller), 162 : controller_(controller),
160 command_updater_(command_updater) { 163 command_updater_(command_updater) {
161 // |profile| can be NULL in tests. 164 // |profile| can be NULL in tests.
162 if (profile) 165 if (profile)
163 model_.reset(new OmniboxEditModel(this, controller, profile)); 166 model_.reset(new OmniboxEditModel(this, controller, profile));
164 } 167 }
165 168
166 void OmniboxView::TextChanged() { 169 void OmniboxView::TextChanged() {
167 EmphasizeURLComponents(); 170 EmphasizeURLComponents();
168 if (model_.get()) 171 if (model_.get())
169 model_->OnChanged(); 172 model_->OnChanged();
170 } 173 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view.h ('k') | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698