Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 299423004: Set fastbuild=0 for ASan and TSan v2 trybots. (Closed)

Created:
6 years, 7 months ago by Alexander Potapenko
Modified:
6 years, 7 months ago
Reviewers:
phajdan
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Set fastbuild=0 for ASan and TSan v2 trybots. We need the debug info for ASan and TSan in order to produce meaningful error reports. The default for trybots is fastbuild=1, which does not disable the debug info for ASan/TSan builds on Linux, but apparently does so for Mac. Also remove the redundant debug info flags which are implied by asan=1. BUG=none TBR=phajdan@chromium.org CC=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=272958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M masters/master.tryserver.chromium/master.cfg View 8 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexander Potapenko
Paweł, can you please take a look? CC Nico (FYI)
6 years, 7 months ago (2014-05-26 16:24:18 UTC) #1
Alexander Potapenko
TBR
6 years, 7 months ago (2014-05-27 13:07:56 UTC) #2
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 7 months ago (2014-05-27 13:08:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/299423004/1
6 years, 7 months ago (2014-05-27 13:08:14 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 13:08:48 UTC) #5
Message was sent while issue was closed.
Change committed as 272958

Powered by Google App Engine
This is Rietveld 408576698