Optimize DDC private library files.

pkg/dev_compiler/tool/input_sdk/private/js_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart._js_helper;
 
 import 'dart:collection';
 
 import 'dart:_debugger' show stackTraceMapper;
 
@@ skipping 55 matching lines @@
     return JS('int', '#', hash);
   }
 
   @NoInline()
   static int _parseIntError(String source, int handleError(String source)) {
     if (handleError == null) throw new FormatException(source);
     return handleError(source);
   }
 
   static int parseInt(
-      String source, int radix, int handleError(String source)) {
-    checkString(source);
+      @nullCheck String source, int _radix, int handleError(String source)) {
     var re = JS('', r'/^\s*[+-]?((0x[a-f0-9]+)|(\d+)|([a-z0-9]+))\s*$/i');
     var/*=JSArray<String>*/ match =
         JS('JSExtendableArray|Null', '#.exec(#)', re, source);
     int digitsIndex = 1;
     int hexIndex = 2;
     int decimalIndex = 3;
     int nonDecimalHexIndex = 4;
     if (match == null) {
       // TODO(sra): It might be that the match failed due to unrecognized U+0085
       // spaces.  We could replace them with U+0020 spaces and try matching
       // again.
       return _parseIntError(source, handleError);
     }
     String decimalMatch = match[decimalIndex];
-    if (radix == null) {
+    if (_radix == null) {
       if (decimalMatch != null) {
         // Cannot fail because we know that the digits are all decimal.
         return JS('int', r'parseInt(#, 10)', source);
       }
       if (match[hexIndex] != null) {
         // Cannot fail because we know that the digits are all hex.
         return JS('int', r'parseInt(#, 16)', source);
       }
       return _parseIntError(source, handleError);
     }
-
-    if (radix is! int) {
-      throw new ArgumentError.value(radix, 'radix', 'is not an integer');
-    }
+    @notNull var radix = _radix;
     if (radix < 2 || radix > 36) {
       throw new RangeError.range(radix, 2, 36, 'radix');
     }
     if (radix == 10 && decimalMatch != null) {
       // Cannot fail because we know that the digits are all decimal.
       return JS('int', r'parseInt(#, 10)', source);
     }
     // If radix >= 10 and we have only decimal digits the string is safe.
     // Otherwise we need to check the digits.
     if (radix < 10 || decimalMatch == null) {
@@ skipping 31 matching lines @@
 
   @NoInline()
   static double _parseDoubleError(
       String source, double handleError(String source)) {
     if (handleError == null) {
       throw new FormatException('Invalid double', source);
     }
     return handleError(source);
   }
 
-  static double parseDouble(String source, double handleError(String source)) {
-    checkString(source);
+  static double parseDouble(@nullCheck String source, double handleError(String source)) {
     // Notice that JS parseFloat accepts garbage at the end of the string.
     // Accept only:
     // - [+/-]NaN
     // - [+/-]Infinity
     // - a Dart double literal
     // We do allow leading or trailing whitespace.
     if (!JS(
         'bool',
         r'/^\s*[+-]?(?:Infinity|NaN|'
         r'(?:\.\d+|\d+(?:\.\d*)?)(?:[eE][+-]?\d+)?)\s*$/.test(#)',
@@ skipping 55 matching lines @@
     // In a browser return self.location.href.
     if (JS('bool', '!!self.location')) {
       return JS('String', 'self.location.href');
     }
 
     return null;
   }
 
   // This is to avoid stack overflows due to very large argument arrays in
   // apply().  It fixes http://dartbug.com/6919
-  static String _fromCharCodeApply(List<int> array) {
+  @notNull static String _fromCharCodeApply(List<int> array) {
     const kMaxApply = 500;
-    int end = array.length;
+    @nullCheck int end = array.length;
     if (end <= kMaxApply) {
       return JS('String', r'String.fromCharCode.apply(null, #)', array);
     }
     String result = '';
     for (int i = 0; i < end; i += kMaxApply) {
       int chunkEnd = (i + kMaxApply < end) ? i + kMaxApply : end;
       result = JS(
           'String',
           r'# + String.fromCharCode.apply(null, #.slice(#, #))',
           result,
           array,
           i,
           chunkEnd);
     }
     return result;
   }
 
-  static String stringFromCodePoints(/*=JSArray<int>*/ codePoints) {
+  @notNull static String stringFromCodePoints(JSArray<int> codePoints) {
     List<int> a = <int>[];
-    for (var i in codePoints) {
-      if (i is! int) throw argumentErrorValue(i);
+    for (@nullCheck var i in codePoints) {
       if (i <= 0xffff) {
         a.add(i);
       } else if (i <= 0x10ffff) {
         a.add(0xd800 + ((((i - 0x10000) >> 10) & 0x3ff)));
         a.add(0xdc00 + (i & 0x3ff));
       } else {
         throw argumentErrorValue(i);
       }
     }
     return _fromCharCodeApply(a);
   }
 
-  static String stringFromCharCodes(/*=JSArray<int>*/ charCodes) {
-    for (var i in charCodes) {
-      if (i is! int) throw argumentErrorValue(i);
+  @notNull static String stringFromCharCodes(JSArray<int> charCodes) {
+    for (@nullCheck var i in charCodes) {
       if (i < 0) throw argumentErrorValue(i);
       if (i > 0xffff) return stringFromCodePoints(charCodes);
     }
     return _fromCharCodeApply(charCodes);
   }
 
   // [start] and [end] are validated.
-  static String stringFromNativeUint8List(
-      NativeUint8List charCodes, int start, int end) {
+  @notNull static String stringFromNativeUint8List(
+      NativeUint8List charCodes, @nullCheck int start, @nullCheck int end) {
     const kMaxApply = 500;
     if (end <= kMaxApply && start == 0 && end == charCodes.length) {
       return JS('String', r'String.fromCharCode.apply(null, #)', charCodes);
     }
     String result = '';
     for (int i = start; i < end; i += kMaxApply) {
       int chunkEnd = (i + kMaxApply < end) ? i + kMaxApply : end;
       result = JS(
           'String',
           r'# + String.fromCharCode.apply(null, #.subarray(#, #))',
           result,
           charCodes,
           i,
           chunkEnd);
     }
     return result;
   }
 
-  static String stringFromCharCode(int charCode) {
+  @notNull static String stringFromCharCode(@nullCheck int charCode) {
     if (0 <= charCode) {
       if (charCode <= 0xffff) {
         return JS('String', 'String.fromCharCode(#)', charCode);
       }
       if (charCode <= 0x10ffff) {
         var bits = charCode - 0x10000;
         var low = 0xDC00 | (bits & 0x3ff);
         var high = 0xD800 | (bits >> 10);
         return JS('String', 'String.fromCharCode(#, #)', high, low);
       }
@@ skipping 42 matching lines @@
     match = JS('JSArray|Null', r'/(?:GMT|UTC)[+-]\d{4}/.exec(#.toString())', d);
     if (match != null) return match[0];
     return "";
   }
 
   static int getTimeZoneOffsetInMinutes(DateTime receiver) {
     // Note that JS and Dart disagree on the sign of the offset.
     return -JS('int', r'#.getTimezoneOffset()', lazyAsJsDate(receiver));
   }
 
-  static num valueFromDecomposedDate(int years, int month, int day, int hours,
-      int minutes, int seconds, int milliseconds, bool isUtc) {
+  static num valueFromDecomposedDate(@nullCheck int years, @nullCheck int month,
+                                     @nullCheck int day, @nullCheck int hours,
+      @nullCheck int minutes, @nullCheck int seconds, @nullCheck int milliseconds,
+                                     @nullCheck bool isUtc) {
     final int MAX_MILLISECONDS_SINCE_EPOCH = 8640000000000000;
-    checkInt(years);
-    checkInt(month);
-    checkInt(day);
-    checkInt(hours);
-    checkInt(minutes);
-    checkInt(seconds);
-    checkInt(milliseconds);
-    checkBool(isUtc);
     var jsMonth = month - 1;
     num value;
     if (isUtc) {
       value = JS('num', r'Date.UTC(#, #, #, #, #, #, #)', years, jsMonth, day,
           hours, minutes, seconds, milliseconds);
     } else {
       value = JS('num', r'new Date(#, #, #, #, #, #, #).valueOf()', years,
           jsMonth, day, hours, minutes, seconds, milliseconds);
     }
     if (value.isNaN ||
@@ skipping 101 matching lines @@
 
   static StackTrace extractStackTrace(Error error) =>
       getTraceFromException(error);
 }
 
 /**
  * Diagnoses an indexing error. Returns the ArgumentError or RangeError that
  * describes the problem.
  */
 @NoInline()
-Error diagnoseIndexError(indexable, index) {
-  if (index is! int) return new ArgumentError.value(index, 'index');
+Error diagnoseIndexError(indexable, int index) {
   int length = indexable.length;
   // The following returns the same error that would be thrown by calling
   // [RangeError.checkValidIndex] with no optional parameters provided.
   if (index < 0 || index >= length) {
     return new RangeError.index(index, indexable, 'index', null, length);
   }
   // The above should always match, but if it does not, use the following.
   return new RangeError.value(index, 'index');
 }
 
 /**
  * Diagnoses a range error. Returns the ArgumentError or RangeError that
  * describes the problem.
  */
 @NoInline()
-Error diagnoseRangeError(start, end, length) {
-  if (start is! int) {
+Error diagnoseRangeError(int start, int end, int length) {
+  if (start == null) {
     return new ArgumentError.value(start, 'start');
   }
   if (start < 0 || start > length) {
     return new RangeError.range(start, 0, length, 'start');
   }
   if (end != null) {
-    if (end is! int) {
-      return new ArgumentError.value(end, 'end');
-    }
     if (end < start || end > length) {
       return new RangeError.range(end, start, length, 'end');
     }
   }
   // The above should always match, but if it does not, use the following.
   return new ArgumentError.value(end, "end");
 }
 
-stringLastIndexOfUnchecked(receiver, element, start) =>
+@notNull int stringLastIndexOfUnchecked(receiver, element, start) =>
     JS('int', r'#.lastIndexOf(#, #)', receiver, element, start);
 
 /// 'factory' for constructing ArgumentError.value to keep the call sites small.
 @NoInline()
 ArgumentError argumentErrorValue(object) {
   return new ArgumentError.value(object);
 }
 
-checkNull(object) {
-  if (object == null) throw argumentErrorValue(object);
-  return object;
-}
-
-checkNum(value) {
-  if (value is! num) throw argumentErrorValue(value);
-  return value;
+void throwArgumentErrorValue(value) {
+  throw argumentErrorValue(value);
 }
 
 checkInt(value) {
   if (value is! int) throw argumentErrorValue(value);
   return value;
 }
 
-checkBool(value) {
-  if (value is! bool) throw argumentErrorValue(value);
-  return value;
-}
-
-checkString(value) {
-  if (value is! String) throw argumentErrorValue(value);
-  return value;
-}
-
 throwRuntimeError(message) {
   throw new RuntimeError(message);
 }
 
 throwAbstractClassInstantiationError(className) {
   throw new AbstractClassInstantiationError(className);
 }
 
 @NoInline()
 throwConcurrentModificationError(collection) {
@@ skipping 338 matching lines @@
     if (dart.polyfill(object)) {
       dart.applyAllExtensions(object);
     }
   } catch (e) {
     // This may fail due to cross-origin errors.  In that case, we shouldn't
     // need to polyfill as we can't get objects from that frame.
 
     // TODO(vsm): Detect this more robustly - ideally before we try to polyfill.
   }
 }