Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2994193002: Updated the status file with MissingCompileTimeError to better indicate expected behavior in dart 1 (Closed)

Created:
3 years, 4 months ago by mkroghj
Modified:
3 years, 4 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updated the status file with MissingCompileTimeError to better indicate expected behavior in dart 1 R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/40b10124b9ee77534b6e8ad93c7f13deef7aab16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tests/language_2/language_2.status View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mkroghj
ptal
3 years, 4 months ago (2017-08-14 08:29:08 UTC) #2
Bill Hesse
lgtm
3 years, 4 months ago (2017-08-14 09:09:49 UTC) #3
mkroghj
3 years, 4 months ago (2017-08-14 10:50:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40b10124b9ee77534b6e8ad93c7f13deef7aab16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698