Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2994143002: [VM logging] Fix nesting of log blocker. (Closed)

Created:
3 years, 4 months ago by regis
Modified:
3 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M runtime/vm/log.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/log.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
regis
3 years, 4 months ago (2017-08-11 18:16:31 UTC) #2
rmacnak
LGTM https://codereview.chromium.org/2994143002/diff/1/runtime/vm/log.h File runtime/vm/log.h (right): https://codereview.chromium.org/2994143002/diff/1/runtime/vm/log.h#newcode55 runtime/vm/log.h:55: void DisableManualFlush(const intptr_t cursor = 0); Parameter is ...
3 years, 4 months ago (2017-08-11 19:36:07 UTC) #3
regis
Thanks! https://codereview.chromium.org/2994143002/diff/1/runtime/vm/log.h File runtime/vm/log.h (right): https://codereview.chromium.org/2994143002/diff/1/runtime/vm/log.h#newcode55 runtime/vm/log.h:55: void DisableManualFlush(const intptr_t cursor = 0); On 2017/08/11 ...
3 years, 4 months ago (2017-08-11 19:43:07 UTC) #4
regis
3 years, 4 months ago (2017-08-11 19:43:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1c268d35df11f65be3f5d5207db075435cace5a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698