Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: runtime/vm/aot_optimizer.cc

Issue 2994113003: [vm] Rename *MintOp to *Int64Op to emphasis that they operate on unboxed values. (Closed)
Patch Set: il-printer Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/constant_propagator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/aot_optimizer.cc
diff --git a/runtime/vm/aot_optimizer.cc b/runtime/vm/aot_optimizer.cc
index ac1a3ac312ec1de68ac9fa48e950b930cafbfaf3..31897ebdd07c4b9b21ee6078db9a2dc75e44f63d 100644
--- a/runtime/vm/aot_optimizer.cc
+++ b/runtime/vm/aot_optimizer.cc
@@ -769,7 +769,7 @@ bool AotOptimizer::TryReplaceWithBinaryOp(InstanceCallInstr* call,
FlowGraphCompiler::SupportsUnboxedMints()) {
// Don't generate mint code if the IC data is marked because of an
// overflow.
- if (ic_data.HasDeoptReason(ICData::kDeoptBinaryMintOp)) return false;
+ if (ic_data.HasDeoptReason(ICData::kDeoptBinaryInt64Op)) return false;
operands_type = kMintCid;
} else if (ShouldSpecializeForDouble(ic_data)) {
operands_type = kDoubleCid;
@@ -816,7 +816,7 @@ bool AotOptimizer::TryReplaceWithBinaryOp(InstanceCallInstr* call,
// Left shift may overflow from smi into mint or big ints.
// Don't generate smi code if the IC data is marked because
// of an overflow.
- if (ic_data.HasDeoptReason(ICData::kDeoptBinaryMintOp)) {
+ if (ic_data.HasDeoptReason(ICData::kDeoptBinaryInt64Op)) {
return false;
}
operands_type = ic_data.HasDeoptReason(ICData::kDeoptBinarySmiOp)
@@ -827,7 +827,7 @@ bool AotOptimizer::TryReplaceWithBinaryOp(InstanceCallInstr* call,
Z, ic_data.AsUnaryClassChecksForArgNr(1)))) {
// Don't generate mint code if the IC data is marked because of an
// overflow.
- if (ic_data.HasDeoptReason(ICData::kDeoptBinaryMintOp)) {
+ if (ic_data.HasDeoptReason(ICData::kDeoptBinaryInt64Op)) {
return false;
}
// Check for smi/mint << smi or smi/mint >> smi.
@@ -878,11 +878,11 @@ bool AotOptimizer::TryReplaceWithBinaryOp(InstanceCallInstr* call,
} else if (operands_type == kMintCid) {
if (!FlowGraphCompiler::SupportsUnboxedMints()) return false;
if ((op_kind == Token::kSHR) || (op_kind == Token::kSHL)) {
- ShiftMintOpInstr* shift_op = new (Z) ShiftMintOpInstr(
+ ShiftInt64OpInstr* shift_op = new (Z) ShiftInt64OpInstr(
op_kind, new (Z) Value(left), new (Z) Value(right), call->deopt_id());
ReplaceCall(call, shift_op);
} else {
- BinaryMintOpInstr* bin_op = new (Z) BinaryMintOpInstr(
+ BinaryInt64OpInstr* bin_op = new (Z) BinaryInt64OpInstr(
op_kind, new (Z) Value(left), new (Z) Value(right), call->deopt_id());
ReplaceCall(call, bin_op);
}
@@ -956,7 +956,7 @@ bool AotOptimizer::TryReplaceWithUnaryOp(InstanceCallInstr* call,
HasOnlySmiOrMint(*call->ic_data()) &&
FlowGraphCompiler::SupportsUnboxedMints()) {
unary_op = new (Z)
- UnaryMintOpInstr(op_kind, new (Z) Value(input), call->deopt_id());
+ UnaryInt64OpInstr(op_kind, new (Z) Value(input), call->deopt_id());
} else if (HasOnlyOneDouble(*call->ic_data()) &&
(op_kind == Token::kNEGATE) && CanUnboxDouble()) {
AddReceiverCheck(call);
@@ -2014,7 +2014,7 @@ void AotOptimizer::VisitStaticCall(StaticCallInstr* call) {
void AotOptimizer::VisitLoadCodeUnits(LoadCodeUnitsInstr* instr) {
// TODO(zerny): Use kUnboxedUint32 once it is fully supported/optimized.
#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_ARM)
- if (!instr->can_pack_into_smi()) instr->set_representation(kUnboxedMint);
+ if (!instr->can_pack_into_smi()) instr->set_representation(kUnboxedInt64);
#endif
}
« no previous file with comments | « no previous file | runtime/vm/constant_propagator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698