Issue 2994113003: [vm] Rename *MintOp to *Int64Op to emphasis that they operate on unboxed values.

Issue 2994113003: [vm] Rename MintOp to Int64Op to emphasis that they operate on unboxed values. (Closed)

Created:
3 years, 4 months ago by rmacnak

Modified:
3 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google), alexmarkov, kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

[vm] Rename *MintOp to *Int64Op to emphasis that they operate on unboxed values. Also rename kUnboxedMint to kUnboxedInt64. R=alexmarkov@google.com, kustermann@google.com, vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/6730d8996fc094724103f2b7b1c22a2fa0c50d74

Patch Set 3 : il-printer #

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -231 lines)			Patch
M	runtime/vm/aot_optimizer.cc	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/constant_propagator.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph.cc	View	1	7 chunks	+11 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_range_analysis.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_range_analysis.cc	View	1	10 chunks	+46 lines, -46 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	18 chunks	+41 lines, -40 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	11 chunks	+14 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	17 chunks	+22 lines, -21 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1	5 chunks	+15 lines, -15 lines	0 comments	Download
M	runtime/vm/intermediate_language_dbc.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	18 chunks	+23 lines, -22 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	16 chunks	+24 lines, -23 lines	0 comments	Download
M	runtime/vm/jit_optimizer.cc	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/locations.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/locations.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 10 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/2994113003/diff/20001/runtime/vm/il_printer.cc File runtime/vm/il_printer.cc (right): https://codereview.chromium.org/2994113003/diff/20001/runtime/vm/il_printer.cc#newcode1083 runtime/vm/il_printer.cc:1083: return "mint"; rename this to int64

3 years, 4 months ago (2017-08-11 01:17:31 UTC) #5

rmacnak

https://codereview.chromium.org/2994113003/diff/20001/runtime/vm/il_printer.cc File runtime/vm/il_printer.cc (right): https://codereview.chromium.org/2994113003/diff/20001/runtime/vm/il_printer.cc#newcode1083 runtime/vm/il_printer.cc:1083: return "mint"; On 2017/08/11 01:17:31, Vyacheslav Egorov (Google) wrote: ...

3 years, 4 months ago (2017-08-11 16:40:56 UTC) #8

rmacnak

3 years, 4 months ago (2017-08-11 16:41:37 UTC) #10

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
6730d8996fc094724103f2b7b1c22a2fa0c50d74 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages