Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issue 2994103002: Add kythe support to plugins and format the spec files (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add kythe support to plugins and format the spec files R=jwren@google.com Committed: https://github.com/dart-lang/sdk/commit/579a0325644a4ffa3c62b8cb9551cc959f9d9b4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1001 lines, -545 lines) Patch
M pkg/analysis_server/doc/api.html View 5 chunks +74 lines, -65 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol_generated.dart View 2 chunks +0 lines, -375 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 10 chunks +36 lines, -104 lines 0 comments Download
M pkg/analyzer_plugin/doc/api.html View 3 chunks +75 lines, -1 line 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_common.dart View 1 chunk +375 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_constants.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart View 1 chunk +211 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart View 1 chunk +32 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart View 2 chunks +63 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/common_types_spec.html View 1 chunk +89 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/plugin_spec.html View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I missed this when reviewing your initial CL, but we want the type definitions to ...
3 years, 4 months ago (2017-08-10 15:41:59 UTC) #2
jwren
lgtm
3 years, 4 months ago (2017-08-10 16:26:05 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-08-10 18:24:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
579a0325644a4ffa3c62b8cb9551cc959f9d9b4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698