Issue 2994073003: [kernel] Set kernel_data in ConvertedClosureFunction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2994073003: [kernel] Set kernel_data in ConvertedClosureFunction (Closed)

Created:
3 years, 4 months ago by jensj

Modified:
3 years, 4 months ago

Reviewers:
sjindel

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[kernel] Set kernel_data in ConvertedClosureFunction kernel_data wasn't set correctly meaning that a crash would occur when trying to compile such a function. BUG= R=sjindel@google.com Committed: https://github.com/dart-lang/sdk/commit/be32512fba8ae2d29c1783110d64f82f6671f97a

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	runtime/vm/kernel_binary_flowgraph.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	runtime/vm/object.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

jensj

3 years, 4 months ago (2017-08-11 10:48:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
be32512fba8ae2d29c1783110d64f82f6671f97a (presubmit successful).