Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2994073002: Remove support for "packages" URL from testing server. (Closed)

Created:
3 years, 4 months ago by Bill Hesse
Modified:
3 years, 4 months ago
Reviewers:
mkroghj, eernst
CC:
reviews_dartlang.org, eernst
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove support for "packages" URL from testing server. This support was only needed for testing Dartium. This also removes the dependency upon package_resolver from test.py. BUG= R=eernst@google.com, mkroghj@google.com Committed: https://github.com/dart-lang/sdk/commit/f38f91bb7e8cceff5149c5ee742d1a501749e4e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -53 lines) Patch
M tools/testing/dart/browser_controller.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/configuration.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tools/testing/dart/http_server.dart View 10 chunks +6 lines, -50 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bill Hesse
3 years, 4 months ago (2017-08-10 11:50:39 UTC) #2
eernst
lgtm
3 years, 4 months ago (2017-08-10 12:02:32 UTC) #4
mkroghj
lgtm
3 years, 4 months ago (2017-08-10 12:32:29 UTC) #5
Bill Hesse
3 years, 4 months ago (2017-08-10 12:33:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f38f91bb7e8cceff5149c5ee742d1a501749e4e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698