Issue 2994053003: Update `String.replaceFirstMapped` documentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2994053003: Update `String.replaceFirstMapped` documentation. (Closed)

Created:
3 years, 4 months ago by floitsch

Modified:
3 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Update `String.replaceFirstMapped` documentation. The result of `replace` must be a String, so no need to mention any other type in the documentation. Fixes #30248. BUG= http://dartbug.com/30248 R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/0d2540989dfedea06e5056ccab6e8f326c03e669

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	sdk/lib/core/string.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Lasse Reichstein Nielsen

lgtm Arguably, the result can still be null, even when correctly typed. I have no ...

3 years, 4 months ago (2017-08-10 15:47:12 UTC) #3

floitsch

3 years, 4 months ago (2017-08-10 16:33:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0d2540989dfedea06e5056ccab6e8f326c03e669 (presubmit successful).