Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chromeos/dbus/fake_shill_service_client.cc

Issue 299403012: Clean up shill fake implementations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/fake_shill_service_client.cc
diff --git a/chromeos/dbus/fake_shill_service_client.cc b/chromeos/dbus/fake_shill_service_client.cc
index 0bb149636b572e7d73e8f047f001c46b035d16ad..6df6ec2a36783b7edde4ad9aa6e81cc387a872f7 100644
--- a/chromeos/dbus/fake_shill_service_client.cc
+++ b/chromeos/dbus/fake_shill_service_client.cc
@@ -308,11 +308,10 @@ void FakeShillServiceClient::AddService(const std::string& service_path,
const std::string& name,
const std::string& type,
const std::string& state,
- bool add_to_visible_list,
- bool add_to_watch_list) {
+ bool add_to_visible_list) {
AddServiceWithIPConfig(service_path, "" /* guid */, name,
type, state, "" /* ipconfig_path */,
- add_to_visible_list, add_to_watch_list);
+ add_to_visible_list);
}
void FakeShillServiceClient::AddServiceWithIPConfig(
@@ -322,10 +321,9 @@ void FakeShillServiceClient::AddServiceWithIPConfig(
const std::string& type,
const std::string& state,
const std::string& ipconfig_path,
- bool add_to_visible_list,
- bool add_to_watch_list) {
+ bool add_to_visible_list) {
DBusThreadManager::Get()->GetShillManagerClient()->GetTestInterface()->
- AddManagerService(service_path, add_to_visible_list, add_to_watch_list);
+ AddManagerService(service_path, add_to_visible_list);
std::string device_path =
DBusThreadManager::Get()->GetShillDeviceClient()->GetTestInterface()->
GetDevicePathForType(type);
@@ -379,8 +377,7 @@ void FakeShillServiceClient::AddServiceWithIPConfig(
new base::StringValue(shill::kSecurityNone));
}
- DBusThreadManager::Get()->GetShillManagerClient()->GetTestInterface()->
- SortManagerServices();
+ CallSortManagerServices();
if (!profile_path.empty()) {
DBusThreadManager::Get()->GetShillProfileClient()->GetTestInterface()->

Powered by Google App Engine
This is Rietveld 408576698