chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc - Issue 299403012: Clean up shill fake implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

Issue 299403012: Clean up shill fake implementations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc ('k') | chrome/browser/chromeos/net/network_portal_detector_test_impl.cc » ('j') | chromeos/network/network_state_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

index a5119bc66466ca3094c7bb0ba2862fbb9555032f..b20cdbdd90be4a3aa58d936bdf1cb8619f549d2e 100644

--- a/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

+++ b/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

@@ -238,31 +238,26 @@ class NetworkPortalDetectorImplTest

DBusThreadManager::Get()->GetShillServiceClient()->GetTestInterface();

service_test->ClearServices();

const bool add_to_visible = true;

- const bool add_to_watchlist = true;

service_test->AddService(kStubEthernet,

kStubEthernet,

shill::kTypeEthernet,

shill::kStateIdle,

- add_to_visible,

- add_to_watchlist);

+ add_to_visible);

service_test->AddService(kStubWireless1,

kStubWireless1,

shill::kTypeWifi,

shill::kStateIdle,

- add_to_visible,

- add_to_watchlist);

+ add_to_visible);

service_test->AddService(kStubWireless2,

kStubWireless2,

shill::kTypeWifi,

shill::kStateIdle,

- add_to_visible,

- add_to_watchlist);

+ add_to_visible);

service_test->AddService(kStubCellular,

kStubCellular,

shill::kTypeCellular,

shill::kStateIdle,

- add_to_visible,

- add_to_watchlist);

+ add_to_visible);

}

void SetupNetworkHandler() {